@@ -2600,16 +2600,13 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
2600
2600
return - EPROBE_DEFER ;
2601
2601
2602
2602
ret = of_parse_phandle_with_fixed_args (np , "gpio-ranges" , 3 , 0 , & of_args );
2603
- if (ret ) {
2604
- dev_err (pctrl -> dev , "Unable to parse gpio-ranges\n" );
2605
- return ret ;
2606
- }
2603
+ if (ret )
2604
+ return dev_err_probe (pctrl -> dev , ret , "Unable to parse gpio-ranges\n" );
2607
2605
2608
2606
if (of_args .args [0 ] != 0 || of_args .args [1 ] != 0 ||
2609
- of_args .args [2 ] != pctrl -> data -> n_port_pins ) {
2610
- dev_err (pctrl -> dev , "gpio-ranges does not match selected SOC\n" );
2611
- return - EINVAL ;
2612
- }
2607
+ of_args .args [2 ] != pctrl -> data -> n_port_pins )
2608
+ return dev_err_probe (pctrl -> dev , - EINVAL ,
2609
+ "gpio-ranges does not match selected SOC\n" );
2613
2610
2614
2611
chip -> names = pctrl -> data -> port_pins ;
2615
2612
chip -> request = rzg2l_gpio_request ;
@@ -2641,10 +2638,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
2641
2638
pctrl -> gpio_range .name = chip -> label ;
2642
2639
pctrl -> gpio_range .gc = chip ;
2643
2640
ret = devm_gpiochip_add_data (pctrl -> dev , chip , pctrl );
2644
- if (ret ) {
2645
- dev_err (pctrl -> dev , "failed to add GPIO controller\n" );
2646
- return ret ;
2647
- }
2641
+ if (ret )
2642
+ return dev_err_probe (pctrl -> dev , ret , "failed to add GPIO controller\n" );
2648
2643
2649
2644
dev_dbg (pctrl -> dev , "Registered gpio controller\n" );
2650
2645
@@ -2730,22 +2725,16 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl)
2730
2725
2731
2726
ret = devm_pinctrl_register_and_init (pctrl -> dev , & pctrl -> desc , pctrl ,
2732
2727
& pctrl -> pctl );
2733
- if (ret ) {
2734
- dev_err (pctrl -> dev , "pinctrl registration failed\n" );
2735
- return ret ;
2736
- }
2728
+ if (ret )
2729
+ return dev_err_probe (pctrl -> dev , ret , "pinctrl registration failed\n" );
2737
2730
2738
2731
ret = pinctrl_enable (pctrl -> pctl );
2739
- if (ret ) {
2740
- dev_err (pctrl -> dev , "pinctrl enable failed\n" );
2741
- return ret ;
2742
- }
2732
+ if (ret )
2733
+ dev_err_probe (pctrl -> dev , ret , "pinctrl enable failed\n" );
2743
2734
2744
2735
ret = rzg2l_gpio_register (pctrl );
2745
- if (ret ) {
2746
- dev_err (pctrl -> dev , "failed to add GPIO chip: %i\n" , ret );
2747
- return ret ;
2748
- }
2736
+ if (ret )
2737
+ return dev_err_probe (pctrl -> dev , ret , "failed to add GPIO chip\n" );
2749
2738
2750
2739
return 0 ;
2751
2740
}
0 commit comments