Skip to content

Commit f73f63b

Browse files
bijudasgeertu
authored andcommitted
pinctrl: renesas: rzg2l: Use dev_err_probe()
Replace dev_err()->dev_err_probe() to simpilfy probe helper functions. Signed-off-by: Biju Das <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent d56abfe commit f73f63b

File tree

1 file changed

+13
-24
lines changed

1 file changed

+13
-24
lines changed

drivers/pinctrl/renesas/pinctrl-rzg2l.c

Lines changed: 13 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2600,16 +2600,13 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
26002600
return -EPROBE_DEFER;
26012601

26022602
ret = of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &of_args);
2603-
if (ret) {
2604-
dev_err(pctrl->dev, "Unable to parse gpio-ranges\n");
2605-
return ret;
2606-
}
2603+
if (ret)
2604+
return dev_err_probe(pctrl->dev, ret, "Unable to parse gpio-ranges\n");
26072605

26082606
if (of_args.args[0] != 0 || of_args.args[1] != 0 ||
2609-
of_args.args[2] != pctrl->data->n_port_pins) {
2610-
dev_err(pctrl->dev, "gpio-ranges does not match selected SOC\n");
2611-
return -EINVAL;
2612-
}
2607+
of_args.args[2] != pctrl->data->n_port_pins)
2608+
return dev_err_probe(pctrl->dev, -EINVAL,
2609+
"gpio-ranges does not match selected SOC\n");
26132610

26142611
chip->names = pctrl->data->port_pins;
26152612
chip->request = rzg2l_gpio_request;
@@ -2641,10 +2638,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
26412638
pctrl->gpio_range.name = chip->label;
26422639
pctrl->gpio_range.gc = chip;
26432640
ret = devm_gpiochip_add_data(pctrl->dev, chip, pctrl);
2644-
if (ret) {
2645-
dev_err(pctrl->dev, "failed to add GPIO controller\n");
2646-
return ret;
2647-
}
2641+
if (ret)
2642+
return dev_err_probe(pctrl->dev, ret, "failed to add GPIO controller\n");
26482643

26492644
dev_dbg(pctrl->dev, "Registered gpio controller\n");
26502645

@@ -2730,22 +2725,16 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl)
27302725

27312726
ret = devm_pinctrl_register_and_init(pctrl->dev, &pctrl->desc, pctrl,
27322727
&pctrl->pctl);
2733-
if (ret) {
2734-
dev_err(pctrl->dev, "pinctrl registration failed\n");
2735-
return ret;
2736-
}
2728+
if (ret)
2729+
return dev_err_probe(pctrl->dev, ret, "pinctrl registration failed\n");
27372730

27382731
ret = pinctrl_enable(pctrl->pctl);
2739-
if (ret) {
2740-
dev_err(pctrl->dev, "pinctrl enable failed\n");
2741-
return ret;
2742-
}
2732+
if (ret)
2733+
dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n");
27432734

27442735
ret = rzg2l_gpio_register(pctrl);
2745-
if (ret) {
2746-
dev_err(pctrl->dev, "failed to add GPIO chip: %i\n", ret);
2747-
return ret;
2748-
}
2736+
if (ret)
2737+
return dev_err_probe(pctrl->dev, ret, "failed to add GPIO chip\n");
27492738

27502739
return 0;
27512740
}

0 commit comments

Comments
 (0)