Skip to content

Commit f76646c

Browse files
ashutoshxlucasdemarchi
authored andcommitted
drm/xe: Label RING_CONTEXT_CONTROL as masked
RING_CONTEXT_CONTROL is a masked register. v2: Also clean up setting register value (Lucas) Reviewed-by: Matt Roper <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Signed-off-by: Ashutosh Dixit <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit dc30c6e) Signed-off-by: Lucas De Marchi <[email protected]>
1 parent 9cb46b3 commit f76646c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

drivers/gpu/drm/xe/regs/xe_engine_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@
125125
#define RING_EXECLIST_STATUS_LO(base) XE_REG((base) + 0x234)
126126
#define RING_EXECLIST_STATUS_HI(base) XE_REG((base) + 0x234 + 4)
127127

128-
#define RING_CONTEXT_CONTROL(base) XE_REG((base) + 0x244)
128+
#define RING_CONTEXT_CONTROL(base) XE_REG((base) + 0x244, XE_REG_OPTION_MASKED)
129129
#define CTX_CTRL_INHIBIT_SYN_CTX_SWITCH REG_BIT(3)
130130
#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT REG_BIT(0)
131131

drivers/gpu/drm/xe/xe_lrc.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,8 @@ static const u8 *reg_offsets(struct xe_device *xe, enum xe_engine_class class)
525525

526526
static void set_context_control(u32 *regs, struct xe_hw_engine *hwe)
527527
{
528-
regs[CTX_CONTEXT_CONTROL] = _MASKED_BIT_ENABLE(CTX_CTRL_INHIBIT_SYN_CTX_SWITCH) |
529-
_MASKED_BIT_DISABLE(CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT) |
530-
CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT;
528+
regs[CTX_CONTEXT_CONTROL] = _MASKED_BIT_ENABLE(CTX_CTRL_INHIBIT_SYN_CTX_SWITCH |
529+
CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT);
531530

532531
/* TODO: Timestamp */
533532
}

0 commit comments

Comments
 (0)