Skip to content

Commit f78d403

Browse files
Wolfram Sangwsakernel
authored andcommitted
drm: encoder_slave: fix refcouting error for modules
module_put() balances try_module_get(), not request_module(). Fix the error path to match that. Fixes: 2066fac ("drm/kms: slave encoder interface.") Signed-off-by: Wolfram Sang <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Acked-by: Daniel Vetter <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent b3a9e3b commit f78d403

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/drm_encoder_slave.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,18 @@ int drm_i2c_encoder_init(struct drm_device *dev,
8484

8585
err = encoder_drv->encoder_init(client, dev, encoder);
8686
if (err)
87-
goto fail_unregister;
87+
goto fail_module_put;
8888

8989
if (info->platform_data)
9090
encoder->slave_funcs->set_config(&encoder->base,
9191
info->platform_data);
9292

9393
return 0;
9494

95+
fail_module_put:
96+
module_put(module);
9597
fail_unregister:
9698
i2c_unregister_device(client);
97-
module_put(module);
9899
fail:
99100
return err;
100101
}

0 commit comments

Comments
 (0)