Skip to content

Commit f793ae1

Browse files
captain5050acmel
authored andcommitted
perf jevents: Remove the type/version variables
pmu_events_map has a type variable that is always initialized to "core" and a version variable that is never read. Remove these from the API as it is straightforward to add them back when necessary. Signed-off-by: Ian Rogers <[email protected]> Cc: Adrian Hunter <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: James Clark <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: John Garry <[email protected]> Cc: Kan Liang <[email protected]> Cc: Leo Yan <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Mike Leach <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Ravi Bangoria <[email protected]> Cc: Stephane Eranian <[email protected]> Cc: Will Deacon <[email protected]> Cc: Xing Zhengjun <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 099b157 commit f793ae1

File tree

5 files changed

+0
-16
lines changed

5 files changed

+0
-16
lines changed

tools/perf/pmu-events/empty-pmu-events.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,11 @@ const struct pmu_events_map pmu_events_map[] = {
112112
{
113113
.arch = "testarch",
114114
.cpuid = "testcpu",
115-
.version = "v1",
116-
.type = "core",
117115
.table = pme_test_soc_cpu,
118116
},
119117
{
120118
.arch = 0,
121119
.cpuid = 0,
122-
.version = 0,
123-
.type = 0,
124120
.table = 0,
125121
},
126122
};

tools/perf/pmu-events/jevents.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,6 @@ def print_mapping_table(archs: Sequence[str]) -> None:
313313
_args.output_file.write("""{
314314
\t.arch = "testarch",
315315
\t.cpuid = "testcpu",
316-
\t.version = "v1",
317-
\t.type = "core",
318316
\t.table = pme_test_soc_cpu,
319317
},
320318
""")
@@ -330,8 +328,6 @@ def print_mapping_table(archs: Sequence[str]) -> None:
330328
_args.output_file.write(f"""{{
331329
\t.arch = "{arch}",
332330
\t.cpuid = "{cpuid}",
333-
\t.version = "{row[1]}",
334-
\t.type = "{row[3]}",
335331
\t.table = {tblname}
336332
}},
337333
""")
@@ -340,8 +336,6 @@ def print_mapping_table(archs: Sequence[str]) -> None:
340336
_args.output_file.write("""{
341337
\t.arch = 0,
342338
\t.cpuid = 0,
343-
\t.version = 0,
344-
\t.type = 0,
345339
\t.table = 0,
346340
}
347341
};

tools/perf/pmu-events/pmu-events.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ struct pmu_event {
4040
struct pmu_events_map {
4141
const char *arch;
4242
const char *cpuid;
43-
const char *version;
44-
const char *type; /* core, uncore etc */
4543
const struct pmu_event *table;
4644
};
4745

tools/perf/tests/expand-cgroup.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ static int expand_metric_events(void)
197197
};
198198
const struct pmu_events_map ev_map = {
199199
.cpuid = "test",
200-
.version = "1",
201-
.type = "core",
202200
.table = pme_test,
203201
};
204202

tools/perf/tests/parse-metric.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ static struct pmu_event pme_test[] = {
8181

8282
static const struct pmu_events_map map = {
8383
.cpuid = "test",
84-
.version = "1",
85-
.type = "core",
8684
.table = pme_test,
8785
};
8886

0 commit comments

Comments
 (0)