Skip to content

Commit f7d5ef0

Browse files
luanshi0212ctmarinas
authored andcommitted
firmware: arm_sdei: clean up sdei_event_create()
Function sdei_event_find() is always called in sdei_event_create(), but it is already called in sdei_event_register(). This code is trying to avoid a double-create of the same event, which can't happen as we still hold the sdei_events_lock. We can remove this needless sdei_event_find() call. Signed-off-by: Liguang Zhang <[email protected]> [expanded commit message] Signed-off-by: James Morse <[email protected]> Signed-off-by: Catalin Marinas <[email protected]>
1 parent 54f529a commit f7d5ef0

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

drivers/firmware/arm_sdei.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -267,15 +267,9 @@ static struct sdei_event *sdei_event_create(u32 event_num,
267267
event->private_registered = regs;
268268
}
269269

270-
if (sdei_event_find(event_num)) {
271-
kfree(event->registered);
272-
kfree(event);
273-
event = ERR_PTR(-EBUSY);
274-
} else {
275-
spin_lock(&sdei_list_lock);
276-
list_add(&event->list, &sdei_list);
277-
spin_unlock(&sdei_list_lock);
278-
}
270+
spin_lock(&sdei_list_lock);
271+
list_add(&event->list, &sdei_list);
272+
spin_unlock(&sdei_list_lock);
279273

280274
return event;
281275
}

0 commit comments

Comments
 (0)