Skip to content

Commit f8086d1

Browse files
rddunlapgregkh
authored andcommitted
serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 8d310c9 ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable") Cc: stable <[email protected]> Signed-off-by: Randy Dunlap <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: Oskar Senft <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2411fd9 commit f8086d1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/tty/serial/8250/Kconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,9 @@ config SERIAL_8250_ASPEED_VUART
257257
tristate "Aspeed Virtual UART"
258258
depends on SERIAL_8250
259259
depends on OF
260-
depends on REGMAP && MFD_SYSCON
260+
depends on MFD_SYSCON
261261
depends on ARCH_ASPEED || COMPILE_TEST
262+
select REGMAP
262263
help
263264
If you want to use the virtual UART (VUART) device on Aspeed
264265
BMC platforms, enable this option. This enables the 16550A-

0 commit comments

Comments
 (0)