Skip to content

Commit f858b57

Browse files
committed
pstore/ram: Adjust module param permissions to reflect reality
A couple module parameters had 0600 permissions, but changing them would have no impact on ramoops, so switch these to 0400 to reflect reality. Link: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Kees Cook <[email protected]>
1 parent d973f7d commit f858b57

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

fs/pstore/ram.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,17 @@ MODULE_PARM_DESC(mem_size,
5353
"size of reserved RAM used to store oops/panic logs");
5454

5555
static unsigned int mem_type;
56-
module_param(mem_type, uint, 0600);
56+
module_param(mem_type, uint, 0400);
5757
MODULE_PARM_DESC(mem_type,
5858
"set to 1 to try to use unbuffered memory (default 0)");
5959

6060
static int dump_oops = 1;
61-
module_param(dump_oops, int, 0600);
61+
module_param(dump_oops, int, 0400);
6262
MODULE_PARM_DESC(dump_oops,
6363
"set to 1 to dump oopses, 0 to only dump panics (default 1)");
6464

6565
static int ramoops_ecc;
66-
module_param_named(ecc, ramoops_ecc, int, 0600);
66+
module_param_named(ecc, ramoops_ecc, int, 0400);
6767
MODULE_PARM_DESC(ramoops_ecc,
6868
"if non-zero, the option enables ECC support and specifies "
6969
"ECC buffer size in bytes (1 is a special value, means 16 "

0 commit comments

Comments
 (0)