Skip to content

Commit f92ae90

Browse files
sudeep-hollaJassiBrar
authored andcommitted
mailbox: pcc: Rename doorbell ack to platform interrupt ack register
The specification refers this register and associated bitmask as platform interrupt acknowledge register. Let us rename it so that it is easier to map and understand. Signed-off-by: Sudeep Holla <[email protected]> Signed-off-by: Jassi Brar <[email protected]>
1 parent 7b6da7f commit f92ae90

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

drivers/mailbox/pcc.c

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,15 @@ static struct mbox_chan *pcc_mbox_channels;
6969
*
7070
* @chan: PCC channel information with Shared Memory Region info
7171
* @db_vaddr: cached virtual address for doorbell register
72-
* @db_ack_vaddr: cached virtual address for doorbell ack register
73-
* @db_irq: doorbell interrupt
72+
* @plat_irq_ack_vaddr: cached virtual address for platform interrupt
73+
* acknowledge register
74+
* @plat_irq: platform interrupt
7475
*/
7576
struct pcc_chan_info {
7677
struct pcc_mbox_chan chan;
7778
void __iomem *db_vaddr;
78-
void __iomem *db_ack_vaddr;
79-
int db_irq;
79+
void __iomem *plat_irq_ack_vaddr;
80+
int plat_irq;
8081
};
8182

8283
#define to_pcc_chan_info(c) container_of(c, struct pcc_chan_info, chan)
@@ -198,12 +199,12 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
198199
doorbell_ack_preserve = pcct2_ss->ack_preserve_mask;
199200
doorbell_ack_write = pcct2_ss->ack_write_mask;
200201

201-
ret = read_register(pchan->db_ack_vaddr,
202+
ret = read_register(pchan->plat_irq_ack_vaddr,
202203
&doorbell_ack_val, doorbell_ack->bit_width);
203204
if (ret)
204205
return IRQ_NONE;
205206

206-
ret = write_register(pchan->db_ack_vaddr,
207+
ret = write_register(pchan->plat_irq_ack_vaddr,
207208
(doorbell_ack_val & doorbell_ack_preserve)
208209
| doorbell_ack_write,
209210
doorbell_ack->bit_width);
@@ -256,14 +257,14 @@ pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id)
256257

257258
spin_unlock_irqrestore(&chan->lock, flags);
258259

259-
if (pchan->db_irq > 0) {
260+
if (pchan->plat_irq > 0) {
260261
int rc;
261262

262-
rc = devm_request_irq(dev, pchan->db_irq, pcc_mbox_irq, 0,
263+
rc = devm_request_irq(dev, pchan->plat_irq, pcc_mbox_irq, 0,
263264
MBOX_IRQ_NAME, chan);
264265
if (unlikely(rc)) {
265266
dev_err(dev, "failed to register PCC interrupt %d\n",
266-
pchan->db_irq);
267+
pchan->plat_irq);
267268
pcc_mbox_free_channel(&pchan->chan);
268269
return ERR_PTR(rc);
269270
}
@@ -288,8 +289,8 @@ void pcc_mbox_free_channel(struct pcc_mbox_chan *pchan)
288289
if (!chan || !chan->cl)
289290
return;
290291

291-
if (pchan_info->db_irq > 0)
292-
devm_free_irq(chan->mbox->dev, pchan_info->db_irq, chan);
292+
if (pchan_info->plat_irq > 0)
293+
devm_free_irq(chan->mbox->dev, pchan_info->plat_irq, chan);
293294

294295
spin_lock_irqsave(&chan->lock, flags);
295296
chan->cl = NULL;
@@ -400,9 +401,9 @@ static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan,
400401
return 0;
401402

402403
pcct_ss = (struct acpi_pcct_hw_reduced *)pcct_entry;
403-
pchan->db_irq = pcc_map_interrupt(pcct_ss->platform_interrupt,
404-
(u32)pcct_ss->flags);
405-
if (pchan->db_irq <= 0) {
404+
pchan->plat_irq = pcc_map_interrupt(pcct_ss->platform_interrupt,
405+
(u32)pcct_ss->flags);
406+
if (pchan->plat_irq <= 0) {
406407
pr_err("PCC GSI %d not registered\n",
407408
pcct_ss->platform_interrupt);
408409
return -EINVAL;
@@ -411,10 +412,10 @@ static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan,
411412
if (pcct_ss->header.type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
412413
struct acpi_pcct_hw_reduced_type2 *pcct2_ss = (void *)pcct_ss;
413414

414-
pchan->db_ack_vaddr =
415+
pchan->plat_irq_ack_vaddr =
415416
acpi_os_ioremap(pcct2_ss->platform_ack_register.address,
416417
pcct2_ss->platform_ack_register.bit_width / 8);
417-
if (!pchan->db_ack_vaddr) {
418+
if (!pchan->plat_irq_ack_vaddr) {
418419
pr_err("Failed to ioremap PCC ACK register\n");
419420
return -ENOMEM;
420421
}

0 commit comments

Comments
 (0)