Skip to content

Commit f92dd14

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: merge Kunit utils and test cases
Merge CROS_KUNIT and CROS_EC_PROTO_KUNIT_TEST so that when they're built as modules cros_kunit_util doesn't need to export the symbols. Signed-off-by: Tzung-Bi Shih <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 7e76e4b commit f92dd14

File tree

3 files changed

+5
-24
lines changed

3 files changed

+5
-24
lines changed

drivers/platform/chrome/Kconfig

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -269,17 +269,11 @@ source "drivers/platform/chrome/wilco_ec/Kconfig"
269269

270270
# Kunit test cases
271271
config CROS_KUNIT
272-
tristate
273-
help
274-
ChromeOS Kunit.
275-
276-
config CROS_EC_PROTO_KUNIT_TEST
277-
tristate "Kunit tests for ChromeOS EC protocol" if !KUNIT_ALL_TESTS
272+
tristate "Kunit tests for ChromeOS" if !KUNIT_ALL_TESTS
278273
depends on KUNIT && CROS_EC
279274
default KUNIT_ALL_TESTS
280275
select CROS_EC_PROTO
281-
select CROS_KUNIT
282276
help
283-
Kunit tests for the ChromeOS Embedded Controller protocol.
277+
ChromeOS Kunit tests.
284278

285279
endif # CHROMEOS_PLATFORMS

drivers/platform/chrome/Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,6 @@ obj-$(CONFIG_CROS_USBPD_NOTIFY) += cros_usbpd_notify.o
3232
obj-$(CONFIG_WILCO_EC) += wilco_ec/
3333

3434
# Kunit test cases
35-
obj-$(CONFIG_CROS_KUNIT) += cros_kunit_util.o
36-
obj-$(CONFIG_CROS_EC_PROTO_KUNIT_TEST) += cros_ec_proto_test.o
35+
obj-$(CONFIG_CROS_KUNIT) += cros_kunit.o
36+
cros_kunit-objs := cros_kunit_util.o
37+
cros_kunit-objs += cros_ec_proto_test.o

drivers/platform/chrome/cros_kunit_util.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@
1414
#include "cros_kunit_util.h"
1515

1616
int cros_kunit_ec_xfer_mock_default_ret;
17-
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
1817
int cros_kunit_ec_cmd_xfer_mock_called;
19-
EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock_called);
2018
int cros_kunit_ec_pkt_xfer_mock_called;
21-
EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock_called);
2219

2320
static struct list_head cros_kunit_ec_xfer_mock_in;
2421
static struct list_head cros_kunit_ec_xfer_mock_out;
@@ -48,27 +45,23 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
4845

4946
return mock->ret;
5047
}
51-
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock);
5248

5349
int cros_kunit_ec_cmd_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
5450
{
5551
++cros_kunit_ec_cmd_xfer_mock_called;
5652
return cros_kunit_ec_xfer_mock(ec_dev, msg);
5753
}
58-
EXPORT_SYMBOL_GPL(cros_kunit_ec_cmd_xfer_mock);
5954

6055
int cros_kunit_ec_pkt_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
6156
{
6257
++cros_kunit_ec_pkt_xfer_mock_called;
6358
return cros_kunit_ec_xfer_mock(ec_dev, msg);
6459
}
65-
EXPORT_SYMBOL_GPL(cros_kunit_ec_pkt_xfer_mock);
6660

6761
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_add(struct kunit *test, size_t size)
6862
{
6963
return cros_kunit_ec_xfer_mock_addx(test, size, EC_RES_SUCCESS, size);
7064
}
71-
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_add);
7265

7366
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
7467
int ret, int result, size_t size)
@@ -91,7 +84,6 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_addx(struct kunit *test,
9184

9285
return mock;
9386
}
94-
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_addx);
9587

9688
struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
9789
{
@@ -103,14 +95,10 @@ struct ec_xfer_mock *cros_kunit_ec_xfer_mock_next(void)
10395

10496
return mock;
10597
}
106-
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_next);
10798

10899
int cros_kunit_readmem_mock_offset;
109-
EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_offset);
110100
u8 *cros_kunit_readmem_mock_data;
111-
EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_data);
112101
int cros_kunit_readmem_mock_ret;
113-
EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock_ret);
114102

115103
int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
116104
unsigned int bytes, void *dest)
@@ -121,7 +109,6 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset,
121109

122110
return cros_kunit_readmem_mock_ret;
123111
}
124-
EXPORT_SYMBOL_GPL(cros_kunit_readmem_mock);
125112

126113
void cros_kunit_mock_reset(void)
127114
{
@@ -135,6 +122,5 @@ void cros_kunit_mock_reset(void)
135122
cros_kunit_readmem_mock_data = NULL;
136123
cros_kunit_readmem_mock_ret = 0;
137124
}
138-
EXPORT_SYMBOL_GPL(cros_kunit_mock_reset);
139125

140126
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)