Skip to content

Commit f95bcb0

Browse files
Alex Hungalexdeucher
authored andcommitted
drm/amd/display: Fix uninitialized variables in DM
This fixes 11 UNINIT issues reported by Coverity. Reviewed-by: Hersen Wu <[email protected]> Acked-by: Wayne Lin <[email protected]> Signed-off-by: Alex Hung <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent e0dd578 commit f95bcb0

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ static u32 dm_vblank_get_counter(struct amdgpu_device *adev, int crtc)
274274
static int dm_crtc_get_scanoutpos(struct amdgpu_device *adev, int crtc,
275275
u32 *vbl, u32 *position)
276276
{
277-
u32 v_blank_start, v_blank_end, h_position, v_position;
277+
u32 v_blank_start = 0, v_blank_end = 0, h_position = 0, v_position = 0;
278278
struct amdgpu_crtc *acrtc = NULL;
279279
struct dc *dc = adev->dm.dc;
280280

@@ -848,7 +848,7 @@ static void dm_handle_hpd_work(struct work_struct *work)
848848
*/
849849
static void dm_dmub_outbox1_low_irq(void *interrupt_params)
850850
{
851-
struct dmub_notification notify;
851+
struct dmub_notification notify = {0};
852852
struct common_irq_params *irq_params = interrupt_params;
853853
struct amdgpu_device *adev = irq_params->adev;
854854
struct amdgpu_display_manager *dm = &adev->dm;
@@ -7208,7 +7208,7 @@ static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state,
72087208
struct amdgpu_dm_connector *aconnector;
72097209
struct dm_connector_state *dm_conn_state;
72107210
int i, j, ret;
7211-
int vcpi, pbn_div, pbn, slot_num = 0;
7211+
int vcpi, pbn_div, pbn = 0, slot_num = 0;
72127212

72137213
for_each_new_connector_in_state(state, connector, new_con_state, i) {
72147214

@@ -10615,7 +10615,7 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
1061510615
struct dm_crtc_state *dm_old_crtc_state, *dm_new_crtc_state;
1061610616
struct drm_dp_mst_topology_mgr *mgr;
1061710617
struct drm_dp_mst_topology_state *mst_state;
10618-
struct dsc_mst_fairness_vars vars[MAX_PIPES];
10618+
struct dsc_mst_fairness_vars vars[MAX_PIPES] = {0};
1061910619

1062010620
trace_amdgpu_dm_atomic_check_begin(state);
1062110621

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ static ssize_t dp_sdp_message_debugfs_write(struct file *f, const char __user *b
12491249
size_t size, loff_t *pos)
12501250
{
12511251
int r;
1252-
uint8_t data[36];
1252+
uint8_t data[36] = {0};
12531253
struct amdgpu_dm_connector *connector = file_inode(f)->i_private;
12541254
struct dm_crtc_state *acrtc_state;
12551255
uint32_t write_size = 36;
@@ -2936,7 +2936,7 @@ static int psr_read_residency(void *data, u64 *val)
29362936
{
29372937
struct amdgpu_dm_connector *connector = data;
29382938
struct dc_link *link = connector->dc_link;
2939-
u32 residency;
2939+
u32 residency = 0;
29402940

29412941
link->dc->link_srv->edp_get_psr_residency(link, &residency);
29422942

0 commit comments

Comments
 (0)