Skip to content

Commit f983714

Browse files
committed
pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug
We are parsing SSBI gpios as fourcell fwspecs but they are twocell. Probably a simple copy-and-paste bug. Tested on the APQ8060 DragonBoard and after this ethernet and MMC card detection works again. Cc: Bjorn Andersson <[email protected]> Cc: [email protected] Reviewed-by: Brian Masney <[email protected]> Fixes: ae436fe ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 3567ee8 commit f983714

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
794794
girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
795795
girq->parent_domain = parent_domain;
796796
girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
797-
girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
797+
girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
798798
girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
799799
girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
800800

0 commit comments

Comments
 (0)