Skip to content

Commit f99d675

Browse files
jwrdegoedeHans Verkuil
authored andcommitted
media: atomisp: Prefix firmware paths with "intel/ipu/"
The atomisp firmwares have been added to upstream linux-firmware under intel/ipu/ add this prefix to the firmware name passed to request_firmware(). Fall back to the old location if this fails to avoid breaking existing setups. Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans Verkuil <[email protected]>
1 parent 19d933c commit f99d675

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,17 +1099,17 @@ atomisp_load_firmware(struct atomisp_device *isp)
10991099

11001100
if ((isp->media_dev.hw_revision >> ATOMISP_HW_REVISION_SHIFT) ==
11011101
ATOMISP_HW_REVISION_ISP2401)
1102-
fw_path = "shisp_2401a0_v21.bin";
1102+
fw_path = "intel/ipu/shisp_2401a0_v21.bin";
11031103

11041104
if (isp->media_dev.hw_revision ==
11051105
((ATOMISP_HW_REVISION_ISP2401_LEGACY << ATOMISP_HW_REVISION_SHIFT) |
11061106
ATOMISP_HW_STEPPING_A0))
1107-
fw_path = "shisp_2401a0_legacy_v21.bin";
1107+
fw_path = "intel/ipu/shisp_2401a0_legacy_v21.bin";
11081108

11091109
if (isp->media_dev.hw_revision ==
11101110
((ATOMISP_HW_REVISION_ISP2400 << ATOMISP_HW_REVISION_SHIFT) |
11111111
ATOMISP_HW_STEPPING_B0))
1112-
fw_path = "shisp_2400b0_v21.bin";
1112+
fw_path = "intel/ipu/shisp_2400b0_v21.bin";
11131113

11141114
if (!fw_path) {
11151115
dev_err(isp->dev, "Unsupported hw_revision 0x%x\n",
@@ -1118,6 +1118,9 @@ atomisp_load_firmware(struct atomisp_device *isp)
11181118
}
11191119

11201120
rc = request_firmware(&fw, fw_path, isp->dev);
1121+
/* Fallback to old fw_path without "intel/ipu/" prefix */
1122+
if (rc)
1123+
rc = request_firmware(&fw, kbasename(fw_path), isp->dev);
11211124
if (rc) {
11221125
dev_err(isp->dev,
11231126
"atomisp: Error %d while requesting firmware %s\n",

0 commit comments

Comments
 (0)