Skip to content

Commit f9d4be2

Browse files
committed
Merge tag 'tty-5.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
Pull tty/serial fixes from Greg KH: "Here are four small tty/serial driver fixes for 5.15-rc3. They include: - remove an export now that no one is using it anymore - mvebu-uart tx_empty callback fix - 8250_omap bugfix - synclink_gt build fix All of these have been in linux-next for a while with no reported issues" * tag 'tty-5.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: tty: unexport tty_ldisc_release tty: synclink_gt: rename a conflicting function name serial: mvebu-uart: fix driver's tx_empty callback serial: 8250: 8250_omap: Fix RX_LVL register offset
2 parents 2c4e969 + 7049d85 commit f9d4be2

File tree

4 files changed

+24
-25
lines changed

4 files changed

+24
-25
lines changed

drivers/tty/serial/8250/8250_omap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
#define UART_OMAP_EFR2_TIMEOUT_BEHAVE BIT(6)
107107

108108
/* RX FIFO occupancy indicator */
109-
#define UART_OMAP_RX_LVL 0x64
109+
#define UART_OMAP_RX_LVL 0x19
110110

111111
struct omap8250_priv {
112112
int line;

drivers/tty/serial/mvebu-uart.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ static unsigned int mvebu_uart_tx_empty(struct uart_port *port)
163163
st = readl(port->membase + UART_STAT);
164164
spin_unlock_irqrestore(&port->lock, flags);
165165

166-
return (st & STAT_TX_FIFO_EMP) ? TIOCSER_TEMT : 0;
166+
return (st & STAT_TX_EMP) ? TIOCSER_TEMT : 0;
167167
}
168168

169169
static unsigned int mvebu_uart_get_mctrl(struct uart_port *port)

drivers/tty/synclink_gt.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,8 @@ static void reset_tbufs(struct slgt_info *info);
438438
static void tdma_reset(struct slgt_info *info);
439439
static bool tx_load(struct slgt_info *info, const char *buf, unsigned int count);
440440

441-
static void get_signals(struct slgt_info *info);
442-
static void set_signals(struct slgt_info *info);
441+
static void get_gtsignals(struct slgt_info *info);
442+
static void set_gtsignals(struct slgt_info *info);
443443
static void set_rate(struct slgt_info *info, u32 data_rate);
444444

445445
static void bh_transmit(struct slgt_info *info);
@@ -720,7 +720,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
720720
if ((old_termios->c_cflag & CBAUD) && !C_BAUD(tty)) {
721721
info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
722722
spin_lock_irqsave(&info->lock,flags);
723-
set_signals(info);
723+
set_gtsignals(info);
724724
spin_unlock_irqrestore(&info->lock,flags);
725725
}
726726

@@ -730,7 +730,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
730730
if (!C_CRTSCTS(tty) || !tty_throttled(tty))
731731
info->signals |= SerialSignal_RTS;
732732
spin_lock_irqsave(&info->lock,flags);
733-
set_signals(info);
733+
set_gtsignals(info);
734734
spin_unlock_irqrestore(&info->lock,flags);
735735
}
736736

@@ -1181,7 +1181,7 @@ static inline void line_info(struct seq_file *m, struct slgt_info *info)
11811181

11821182
/* output current serial signal states */
11831183
spin_lock_irqsave(&info->lock,flags);
1184-
get_signals(info);
1184+
get_gtsignals(info);
11851185
spin_unlock_irqrestore(&info->lock,flags);
11861186

11871187
stat_buf[0] = 0;
@@ -1281,7 +1281,7 @@ static void throttle(struct tty_struct * tty)
12811281
if (C_CRTSCTS(tty)) {
12821282
spin_lock_irqsave(&info->lock,flags);
12831283
info->signals &= ~SerialSignal_RTS;
1284-
set_signals(info);
1284+
set_gtsignals(info);
12851285
spin_unlock_irqrestore(&info->lock,flags);
12861286
}
12871287
}
@@ -1306,7 +1306,7 @@ static void unthrottle(struct tty_struct * tty)
13061306
if (C_CRTSCTS(tty)) {
13071307
spin_lock_irqsave(&info->lock,flags);
13081308
info->signals |= SerialSignal_RTS;
1309-
set_signals(info);
1309+
set_gtsignals(info);
13101310
spin_unlock_irqrestore(&info->lock,flags);
13111311
}
13121312
}
@@ -1477,7 +1477,7 @@ static int hdlcdev_open(struct net_device *dev)
14771477

14781478
/* inform generic HDLC layer of current DCD status */
14791479
spin_lock_irqsave(&info->lock, flags);
1480-
get_signals(info);
1480+
get_gtsignals(info);
14811481
spin_unlock_irqrestore(&info->lock, flags);
14821482
if (info->signals & SerialSignal_DCD)
14831483
netif_carrier_on(dev);
@@ -2229,7 +2229,7 @@ static void isr_txeom(struct slgt_info *info, unsigned short status)
22292229
if (info->params.mode != MGSL_MODE_ASYNC && info->drop_rts_on_tx_done) {
22302230
info->signals &= ~SerialSignal_RTS;
22312231
info->drop_rts_on_tx_done = false;
2232-
set_signals(info);
2232+
set_gtsignals(info);
22332233
}
22342234

22352235
#if SYNCLINK_GENERIC_HDLC
@@ -2394,7 +2394,7 @@ static void shutdown(struct slgt_info *info)
23942394

23952395
if (!info->port.tty || info->port.tty->termios.c_cflag & HUPCL) {
23962396
info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
2397-
set_signals(info);
2397+
set_gtsignals(info);
23982398
}
23992399

24002400
flush_cond_wait(&info->gpio_wait_q);
@@ -2422,15 +2422,15 @@ static void program_hw(struct slgt_info *info)
24222422
else
24232423
async_mode(info);
24242424

2425-
set_signals(info);
2425+
set_gtsignals(info);
24262426

24272427
info->dcd_chkcount = 0;
24282428
info->cts_chkcount = 0;
24292429
info->ri_chkcount = 0;
24302430
info->dsr_chkcount = 0;
24312431

24322432
slgt_irq_on(info, IRQ_DCD | IRQ_CTS | IRQ_DSR | IRQ_RI);
2433-
get_signals(info);
2433+
get_gtsignals(info);
24342434

24352435
if (info->netcount ||
24362436
(info->port.tty && info->port.tty->termios.c_cflag & CREAD))
@@ -2667,7 +2667,7 @@ static int wait_mgsl_event(struct slgt_info *info, int __user *mask_ptr)
26672667
spin_lock_irqsave(&info->lock,flags);
26682668

26692669
/* return immediately if state matches requested events */
2670-
get_signals(info);
2670+
get_gtsignals(info);
26712671
s = info->signals;
26722672

26732673
events = mask &
@@ -3085,7 +3085,7 @@ static int tiocmget(struct tty_struct *tty)
30853085
unsigned long flags;
30863086

30873087
spin_lock_irqsave(&info->lock,flags);
3088-
get_signals(info);
3088+
get_gtsignals(info);
30893089
spin_unlock_irqrestore(&info->lock,flags);
30903090

30913091
result = ((info->signals & SerialSignal_RTS) ? TIOCM_RTS:0) +
@@ -3124,7 +3124,7 @@ static int tiocmset(struct tty_struct *tty,
31243124
info->signals &= ~SerialSignal_DTR;
31253125

31263126
spin_lock_irqsave(&info->lock,flags);
3127-
set_signals(info);
3127+
set_gtsignals(info);
31283128
spin_unlock_irqrestore(&info->lock,flags);
31293129
return 0;
31303130
}
@@ -3135,7 +3135,7 @@ static int carrier_raised(struct tty_port *port)
31353135
struct slgt_info *info = container_of(port, struct slgt_info, port);
31363136

31373137
spin_lock_irqsave(&info->lock,flags);
3138-
get_signals(info);
3138+
get_gtsignals(info);
31393139
spin_unlock_irqrestore(&info->lock,flags);
31403140
return (info->signals & SerialSignal_DCD) ? 1 : 0;
31413141
}
@@ -3150,7 +3150,7 @@ static void dtr_rts(struct tty_port *port, int on)
31503150
info->signals |= SerialSignal_RTS | SerialSignal_DTR;
31513151
else
31523152
info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
3153-
set_signals(info);
3153+
set_gtsignals(info);
31543154
spin_unlock_irqrestore(&info->lock,flags);
31553155
}
31563156

@@ -3948,10 +3948,10 @@ static void tx_start(struct slgt_info *info)
39483948

39493949
if (info->params.mode != MGSL_MODE_ASYNC) {
39503950
if (info->params.flags & HDLC_FLAG_AUTO_RTS) {
3951-
get_signals(info);
3951+
get_gtsignals(info);
39523952
if (!(info->signals & SerialSignal_RTS)) {
39533953
info->signals |= SerialSignal_RTS;
3954-
set_signals(info);
3954+
set_gtsignals(info);
39553955
info->drop_rts_on_tx_done = true;
39563956
}
39573957
}
@@ -4005,7 +4005,7 @@ static void reset_port(struct slgt_info *info)
40054005
rx_stop(info);
40064006

40074007
info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
4008-
set_signals(info);
4008+
set_gtsignals(info);
40094009

40104010
slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
40114011
}
@@ -4427,7 +4427,7 @@ static void tx_set_idle(struct slgt_info *info)
44274427
/*
44284428
* get state of V24 status (input) signals
44294429
*/
4430-
static void get_signals(struct slgt_info *info)
4430+
static void get_gtsignals(struct slgt_info *info)
44314431
{
44324432
unsigned short status = rd_reg16(info, SSR);
44334433

@@ -4489,7 +4489,7 @@ static void msc_set_vcr(struct slgt_info *info)
44894489
/*
44904490
* set state of V24 control (output) signals
44914491
*/
4492-
static void set_signals(struct slgt_info *info)
4492+
static void set_gtsignals(struct slgt_info *info)
44934493
{
44944494
unsigned char val = rd_reg8(info, VCR);
44954495
if (info->signals & SerialSignal_DTR)

drivers/tty/tty_ldisc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -812,7 +812,6 @@ void tty_ldisc_release(struct tty_struct *tty)
812812

813813
tty_ldisc_debug(tty, "released\n");
814814
}
815-
EXPORT_SYMBOL_GPL(tty_ldisc_release);
816815

817816
/**
818817
* tty_ldisc_init - ldisc setup for new tty

0 commit comments

Comments
 (0)