Skip to content

Commit f9f21ce

Browse files
bebarinoKAGA-KOKO
authored andcommitted
genirq: Clarify that irq wake state is orthogonal to enable/disable
There's some confusion around if an irq that's disabled with disable_irq() can still wake the system from sleep states such as "suspend to RAM". Clarify this in the kernel documentation for irq_set_irq_wake() so that it's clear that an irq can be disabled and still wake the system if it has been marked for wakeup. Signed-off-by: Stephen Boyd <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Reviewed-by: Douglas Anderson <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 90568ec commit f9f21ce

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

kernel/irq/manage.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -731,6 +731,13 @@ static int set_irq_wake_real(unsigned int irq, unsigned int on)
731731
*
732732
* Wakeup mode lets this IRQ wake the system from sleep
733733
* states like "suspend to RAM".
734+
*
735+
* Note: irq enable/disable state is completely orthogonal
736+
* to the enable/disable state of irq wake. An irq can be
737+
* disabled with disable_irq() and still wake the system as
738+
* long as the irq has wake enabled. If this does not hold,
739+
* then the underlying irq chip and the related driver need
740+
* to be investigated.
734741
*/
735742
int irq_set_irq_wake(unsigned int irq, unsigned int on)
736743
{

0 commit comments

Comments
 (0)