Skip to content

Commit fa398e6

Browse files
lorelei-sakaiMikulas Patocka
authored andcommitted
dm vdo repair: add missing kerneldoc fields
Also remove trivial comment for increment_recovery_point. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9518 Signed-off-by: Matthew Sakai <[email protected]> Signed-off-by: Mikulas Patocka <[email protected]>
1 parent 0b60be1 commit fa398e6

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/md/dm-vdo/repair.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ static bool __must_check abort_on_error(int result, struct repair_completion *re
318318
/**
319319
* drain_slab_depot() - Flush out all dirty refcounts blocks now that they have been rebuilt or
320320
* recovered.
321+
* @completion: The repair completion.
321322
*/
322323
static void drain_slab_depot(struct vdo_completion *completion)
323324
{
@@ -653,9 +654,6 @@ static void rebuild_reference_counts(struct vdo_completion *completion)
653654
vdo_traverse_forest(vdo->block_map, process_entry, completion);
654655
}
655656

656-
/**
657-
* increment_recovery_point() - Move the given recovery point forward by one entry.
658-
*/
659657
static void increment_recovery_point(struct recovery_point *point)
660658
{
661659
if (++point->entry_count < RECOVERY_JOURNAL_ENTRIES_PER_SECTOR)
@@ -952,6 +950,7 @@ static void abort_block_map_recovery(struct repair_completion *repair, int resul
952950
/**
953951
* find_entry_starting_next_page() - Find the first journal entry after a given entry which is not
954952
* on the same block map page.
953+
* @repair: The repair completion.
955954
* @current_entry: The entry to search from.
956955
* @needs_sort: Whether sorting is needed to proceed.
957956
*
@@ -1218,6 +1217,7 @@ static bool __must_check is_exact_recovery_journal_block(const struct recovery_j
12181217

12191218
/**
12201219
* find_recovery_journal_head_and_tail() - Find the tail and head of the journal.
1220+
* @repair: The repair completion.
12211221
*
12221222
* Return: True if there were valid journal blocks.
12231223
*/
@@ -1446,6 +1446,7 @@ static int validate_heads(struct repair_completion *repair)
14461446

14471447
/**
14481448
* extract_new_mappings() - Find all valid new mappings to be applied to the block map.
1449+
* @repair: The repair completion.
14491450
*
14501451
* The mappings are extracted from the journal and stored in a sortable array so that all of the
14511452
* mappings to be applied to a given block map page can be done in a single page fetch.
@@ -1500,6 +1501,7 @@ static int extract_new_mappings(struct repair_completion *repair)
15001501
/**
15011502
* compute_usages() - Compute the lbns in use and block map data blocks counts from the tail of
15021503
* the journal.
1504+
* @repair: The repair completion.
15031505
*/
15041506
static noinline int compute_usages(struct repair_completion *repair)
15051507
{

0 commit comments

Comments
 (0)