Skip to content

Commit faaa222

Browse files
Uwe Kleine-Königthierryreding
authored andcommitted
pwm: omap-dmtimer: Don't check the return code of pwmchip_remove()
pwmchip_remove() returns always 0. Don't use the value to make it possible to eventually change the function to return void. Also the driver core ignores the return value of pwm_omap_dmtimer_remove() and considers the device removed anyhow. So returning early results in a resource leak. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
1 parent 9b7b573 commit faaa222

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/pwm/pwm-omap-dmtimer.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,11 +444,8 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
444444
static int pwm_omap_dmtimer_remove(struct platform_device *pdev)
445445
{
446446
struct pwm_omap_dmtimer_chip *omap = platform_get_drvdata(pdev);
447-
int ret;
448447

449-
ret = pwmchip_remove(&omap->chip);
450-
if (ret)
451-
return ret;
448+
pwmchip_remove(&omap->chip);
452449

453450
if (pm_runtime_active(&omap->dm_timer_pdev->dev))
454451
omap->pdata->stop(omap->dm_timer);

0 commit comments

Comments
 (0)