Skip to content

Commit fac888b

Browse files
luo penghaotytso
authored andcommitted
ext4: remove unused assignments
The eh assignment in these two places is meaningless, because the function will goto to merge, which will not use eh. The clang_analyzer complains as follows: fs/ext4/extents.c:1988:4 warning: fs/ext4/extents.c:2016:4 warning: Value stored to 'eh' is never read Reported-by: Zeal Robot <[email protected]> Signed-off-by: luo penghao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Theodore Ts'o <[email protected]>
1 parent a660be9 commit fac888b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/ext4/extents.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2025,7 +2025,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
20252025
+ ext4_ext_get_actual_len(newext));
20262026
if (unwritten)
20272027
ext4_ext_mark_unwritten(ex);
2028-
eh = path[depth].p_hdr;
20292028
nearex = ex;
20302029
goto merge;
20312030
}
@@ -2054,7 +2053,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
20542053
+ ext4_ext_get_actual_len(newext));
20552054
if (unwritten)
20562055
ext4_ext_mark_unwritten(ex);
2057-
eh = path[depth].p_hdr;
20582056
nearex = ex;
20592057
goto merge;
20602058
}

0 commit comments

Comments
 (0)