Skip to content

Commit fae633c

Browse files
darcarirafaeljw
authored andcommitted
thermal: intel: powerclamp: fix mismatch in get function for max_idle
KASAN reported this [ 444.853098] BUG: KASAN: global-out-of-bounds in param_get_int+0x77/0x90 [ 444.853111] Read of size 4 at addr ffffffffc16c9220 by task cat/2105 ... [ 444.853442] The buggy address belongs to the variable: [ 444.853443] max_idle+0x0/0xffffffffffffcde0 [intel_powerclamp] There is a mismatch between the param_get_int and the definition of max_idle. Replacing param_get_int with param_get_byte resolves this issue. Fixes: ebf5197 ("thermal: intel: powerclamp: Add two module parameters") Cc: 6.3+ <[email protected]> # 6.3+ Signed-off-by: David Arcari <[email protected]> Reviewed-by: Srinivas Pandruvada <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent cd3c00e commit fae633c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/thermal/intel/intel_powerclamp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ static int max_idle_set(const char *arg, const struct kernel_param *kp)
256256

257257
static const struct kernel_param_ops max_idle_ops = {
258258
.set = max_idle_set,
259-
.get = param_get_int,
259+
.get = param_get_byte,
260260
};
261261

262262
module_param_cb(max_idle, &max_idle_ops, &max_idle, 0644);

0 commit comments

Comments
 (0)