nfs/localio: remove redundant suid/sgid handling

Mike Snitzer · Trond Myklebust · commit fb4e525da1c1 · 2024-11-08T14:26:20.000-05:00
nfs_writeback_done() will take care of suid/sgid corner case.

Signed-off-by: Mike Snitzer &lt;snitzer@kernel.org&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/fs/nfs/localio.c b/fs/nfs/localio.c
@@ -521,12 +521,7 @@ nfs_local_write_done(struct nfs_local_kiocb *iocb, long status)
 	}
 	if (status < 0)
 		nfs_reset_boot_verifier(inode);
-	else if (nfs_should_remove_suid(inode)) {
-		/* Deal with the suid/sgid bit corner case */
-		spin_lock(&inode->i_lock);
-		nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE);
-		spin_unlock(&inode->i_lock);
-	}
+
 	nfs_local_pgio_done(hdr, status);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -521,12 +521,7 @@ nfs_local_write_done(struct nfs_local_kiocb *iocb, long status)`
`521`	`521`	`}`
`522`	`522`	`if (status < 0)`
`523`	`523`	`nfs_reset_boot_verifier(inode);`
`524`		`- else if (nfs_should_remove_suid(inode)) {`
`525`		`- /* Deal with the suid/sgid bit corner case */`
`526`		`- spin_lock(&inode->i_lock);`
`527`		`- nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE);`
`528`		`- spin_unlock(&inode->i_lock);`
`529`		`- }`
	`524`	`+`
`530`	`525`	`nfs_local_pgio_done(hdr, status);`
`531`	`526`	`}`
`532`	`527`