Skip to content

Commit fb80ef6

Browse files
quic-bjorandeandersson
authored andcommitted
rpmsg: glink: Release driver_override
Upon termination of the rpmsg_device, driver_override needs to be freed to avoid leaking the potentially assigned string. Fixes: 42cd402 ("rpmsg: Fix kfree() of static memory on setting driver_override") Fixes: 39e4776 ("rpmsg: Add driver_override device attribute for rpmsg_device") Reviewed-by: Chris Lew <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 3e74ec2 commit fb80ef6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/rpmsg/qcom_glink_native.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1455,6 +1455,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
14551455
{
14561456
struct rpmsg_device *rpdev = to_rpmsg_device(dev);
14571457

1458+
kfree(rpdev->driver_override);
14581459
kfree(rpdev);
14591460
}
14601461

@@ -1698,6 +1699,7 @@ static void qcom_glink_device_release(struct device *dev)
16981699

16991700
/* Release qcom_glink_alloc_channel() reference */
17001701
kref_put(&channel->refcount, qcom_glink_channel_release);
1702+
kfree(rpdev->driver_override);
17011703
kfree(rpdev);
17021704
}
17031705

0 commit comments

Comments
 (0)