Skip to content

Commit fb9024b

Browse files
Ewan D. Milnemartinkpetersen
authored andcommitted
scsi: qla2xxx: Do not log message when reading port speed via sysfs
Calling ql_log() inside qla2x00_port_speed_show() is causing messages to be output to the console for no particularly good reason. The sysfs read routine should just return the information to userspace. The only reason to log a message is when the port speed actually changes, and this already occurs elsewhere. Link: https://lore.kernel.org/r/[email protected] Fixes: 4910b52 ("scsi: qla2xxx: Add support for setting port speed") Cc: <[email protected]> # v5.1+ Reviewed-by: Lee Duncan <[email protected]> Reviewed-by: Laurence Oberman <[email protected]> Reviewed-by: Himanshu Madhani <[email protected]> Signed-off-by: Ewan D. Milne <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent b365221 commit fb9024b

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/scsi/qla2xxx/qla_attr.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1850,9 +1850,6 @@ qla2x00_port_speed_show(struct device *dev, struct device_attribute *attr,
18501850
return -EINVAL;
18511851
}
18521852

1853-
ql_log(ql_log_info, vha, 0x70d6,
1854-
"port speed:%d\n", ha->link_data_rate);
1855-
18561853
return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]);
18571854
}
18581855

0 commit comments

Comments
 (0)