Skip to content

Commit fcab163

Browse files
andres-embbroonie
authored andcommitted
spi: offload: check for match callback when a trigger is being registered
Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safely invoke the callback when it is required In v2: - improve readability of the condition Signed-off-by: Andres Urian Florez <[email protected]> Reviewed-by: David Lechner <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent cbc9d9e commit fcab163

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-offload.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev,
434434
{
435435
struct spi_offload_trigger *trigger;
436436

437-
if (!info->fwnode || !info->ops)
437+
if (!info->fwnode || !info->ops || !info->ops->match)
438438
return -EINVAL;
439439

440440
trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);

0 commit comments

Comments
 (0)