Skip to content

Commit fcd7c9c

Browse files
Valentin SchneiderPeter Zijlstra
authored andcommitted
arm, arm64: Fix selection of CONFIG_SCHED_THERMAL_PRESSURE
Qian reported that the current setup forgoes the Kconfig dependencies and results in warnings such as: WARNING: unmet direct dependencies detected for SCHED_THERMAL_PRESSURE Depends on [n]: SMP [=y] && CPU_FREQ_THERMAL [=n] Selected by [y]: - ARM64 [=y] Revert commit e17ae7f ("arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE") and re-implement it by making the option default to 'y' for arm64 and arm, which respects Kconfig dependencies (i.e. will remain 'n' if CPU_FREQ_THERMAL=n). Fixes: e17ae7f ("arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE") Reported-by: Qian Cai <[email protected]> Signed-off-by: Valentin Schneider <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 1f73d1a commit fcd7c9c

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

arch/arm/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ config ARM
4646
select EDAC_ATOMIC_SCRUB
4747
select GENERIC_ALLOCATOR
4848
select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY
49-
select SCHED_THERMAL_PRESSURE if ARM_CPU_TOPOLOGY
5049
select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI
5150
select GENERIC_CLOCKEVENTS_BROADCAST if SMP
5251
select GENERIC_CPU_AUTOPROBE

arch/arm64/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ config ARM64
192192
select PCI_SYSCALL if PCI
193193
select POWER_RESET
194194
select POWER_SUPPLY
195-
select SCHED_THERMAL_PRESSURE
196195
select SPARSE_IRQ
197196
select SWIOTLB
198197
select SYSCTL_EXCEPTION_TRACE

init/Kconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -493,6 +493,8 @@ config HAVE_SCHED_AVG_IRQ
493493

494494
config SCHED_THERMAL_PRESSURE
495495
bool
496+
default y if ARM && ARM_CPU_TOPOLOGY
497+
default y if ARM64
496498
depends on SMP
497499
depends on CPU_FREQ_THERMAL
498500
help

0 commit comments

Comments
 (0)