Skip to content

Commit fcea0cc

Browse files
sudeep-hollactmarinas
authored andcommitted
ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()
Move all of the ARM-specific initialization into one function namely acpi_arm_init(), so it is not necessary to modify/update bus.c every time a new piece of it is added. Cc: Lorenzo Pieralisi <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Suggested-by: Rafael J. Wysocki <[email protected]> Reviewed-by: Robin Murphy <[email protected]> Reviewed-by: Hanjun Guo <[email protected]> Link: https://lore.kernel.org/r/CAJZ5v0iBZRZmV_oU+VurqxnVMbFN_ttqrL=cLh0sUH+=u0PYsw@mail.gmail.com Signed-off-by: Sudeep Holla <[email protected]> Reviewed-by: Lorenzo Pieralisi <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Reviewed-by: Shaoqin Huang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
1 parent 44c026a commit fcea0cc

File tree

11 files changed

+30
-43
lines changed

11 files changed

+30
-43
lines changed

drivers/acpi/arm64/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ obj-$(CONFIG_ACPI_AGDI) += agdi.o
33
obj-$(CONFIG_ACPI_IORT) += iort.o
44
obj-$(CONFIG_ACPI_GTDT) += gtdt.o
55
obj-$(CONFIG_ACPI_APMT) += apmt.o
6-
obj-y += dma.o
6+
obj-y += dma.o init.o

drivers/acpi/arm64/agdi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
#define pr_fmt(fmt) "ACPI: AGDI: " fmt
1010

1111
#include <linux/acpi.h>
12-
#include <linux/acpi_agdi.h>
1312
#include <linux/arm_sdei.h>
1413
#include <linux/io.h>
1514
#include <linux/kernel.h>
1615
#include <linux/platform_device.h>
16+
#include "init.h"
1717

1818
struct agdi_data {
1919
int sdei_event;

drivers/acpi/arm64/apmt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
#define pr_fmt(fmt) "ACPI: APMT: " fmt
1111

1212
#include <linux/acpi.h>
13-
#include <linux/acpi_apmt.h>
1413
#include <linux/init.h>
1514
#include <linux/kernel.h>
1615
#include <linux/platform_device.h>
16+
#include "init.h"
1717

1818
#define DEV_NAME "arm-cs-arch-pmu"
1919

drivers/acpi/arm64/init.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// SPDX-License-Identifier: GPL-2.0-only
2+
#include <linux/acpi.h>
3+
#include "init.h"
4+
5+
void __init acpi_arm_init(void)
6+
{
7+
if (IS_ENABLED(CONFIG_ACPI_AGDI))
8+
acpi_agdi_init();
9+
if (IS_ENABLED(CONFIG_ACPI_APMT))
10+
acpi_apmt_init();
11+
if (IS_ENABLED(CONFIG_ACPI_IORT))
12+
acpi_iort_init();
13+
}

drivers/acpi/arm64/init.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/* SPDX-License-Identifier: GPL-2.0-only */
2+
#include <linux/init.h>
3+
4+
void __init acpi_agdi_init(void);
5+
void __init acpi_apmt_init(void);
6+
void __init acpi_iort_init(void);

drivers/acpi/arm64/iort.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include <linux/platform_device.h>
2020
#include <linux/slab.h>
2121
#include <linux/dma-map-ops.h>
22+
#include "init.h"
2223

2324
#define IORT_TYPE_MASK(type) (1 << (type))
2425
#define IORT_MSI_TYPE (1 << ACPI_IORT_NODE_ITS_GROUP)

drivers/acpi/bus.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
#include <asm/mpspec.h>
2727
#include <linux/dmi.h>
2828
#endif
29-
#include <linux/acpi_agdi.h>
30-
#include <linux/acpi_apmt.h>
31-
#include <linux/acpi_iort.h>
3229
#include <linux/acpi_viot.h>
3330
#include <linux/pci.h>
3431
#include <acpi/apei.h>
@@ -1408,7 +1405,7 @@ static int __init acpi_init(void)
14081405
acpi_init_ffh();
14091406

14101407
pci_mmcfg_late_init();
1411-
acpi_iort_init();
1408+
acpi_arm_init();
14121409
acpi_viot_early_init();
14131410
acpi_hest_init();
14141411
acpi_ghes_init();
@@ -1420,8 +1417,6 @@ static int __init acpi_init(void)
14201417
acpi_debugger_init();
14211418
acpi_setup_sb_notify_handler();
14221419
acpi_viot_init();
1423-
acpi_agdi_init();
1424-
acpi_apmt_init();
14251420
return 0;
14261421
}
14271422

include/linux/acpi.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1507,6 +1507,12 @@ static inline int find_acpi_cpu_topology_hetero_id(unsigned int cpu)
15071507
}
15081508
#endif
15091509

1510+
#ifdef CONFIG_ARM64
1511+
void acpi_arm_init(void);
1512+
#else
1513+
static inline void acpi_arm_init(void) { }
1514+
#endif
1515+
15101516
#ifdef CONFIG_ACPI_PCC
15111517
void acpi_init_pcc(void);
15121518
#else

include/linux/acpi_agdi.h

Lines changed: 0 additions & 13 deletions
This file was deleted.

include/linux/acpi_apmt.h

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)