Skip to content

Commit fcf5d35

Browse files
arndbvinodkoul
authored andcommitted
phy: rockchip: fix Kconfig dependency more
A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable: aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe': phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed' Select CONFIG_USB_COMMON directly here, like we do in some other phy drivers, to make sure this is available even when actual USB support is disabled or in a loadable module that cannot be reached from a built-in phy driver. Fixes: 9c79b77 ("phy: rockchip: fix CONFIG_TYPEC dependency") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Sebastian Reichel <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 2014c95 commit fcf5d35

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/phy/rockchip/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP
125125
depends on ARCH_ROCKCHIP && OF
126126
depends on TYPEC
127127
select GENERIC_PHY
128+
select USB_COMMON
128129
help
129130
Enable this to support the Rockchip USB3.0/DP combo PHY with
130131
Samsung IP block. This is required for USB3 support on RK3588.

0 commit comments

Comments
 (0)