Skip to content

Commit fd4a809

Browse files
khayash1davem330
authored andcommitted
net: socionext: ave: Avoid using netdev_err() before calling register_netdev()
Until calling register_netdev(), ndev->dev_name isn't specified, and netdev_err() displays "(unnamed net_device)". ave 65000000.ethernet (unnamed net_device) (uninitialized): invalid phy-mode setting ave: probe of 65000000.ethernet failed with error -22 This replaces netdev_err() with dev_err() before calling register_netdev(). Signed-off-by: Kunihiko Hayashi <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2df4de1 commit fd4a809

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ethernet/socionext/sni_ave.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,19 +1662,19 @@ static int ave_probe(struct platform_device *pdev)
16621662
"socionext,syscon-phy-mode",
16631663
1, 0, &args);
16641664
if (ret) {
1665-
netdev_err(ndev, "can't get syscon-phy-mode property\n");
1665+
dev_err(dev, "can't get syscon-phy-mode property\n");
16661666
goto out_free_netdev;
16671667
}
16681668
priv->regmap = syscon_node_to_regmap(args.np);
16691669
of_node_put(args.np);
16701670
if (IS_ERR(priv->regmap)) {
1671-
netdev_err(ndev, "can't map syscon-phy-mode\n");
1671+
dev_err(dev, "can't map syscon-phy-mode\n");
16721672
ret = PTR_ERR(priv->regmap);
16731673
goto out_free_netdev;
16741674
}
16751675
ret = priv->data->get_pinmode(priv, phy_mode, args.args[0]);
16761676
if (ret) {
1677-
netdev_err(ndev, "invalid phy-mode setting\n");
1677+
dev_err(dev, "invalid phy-mode setting\n");
16781678
goto out_free_netdev;
16791679
}
16801680

0 commit comments

Comments
 (0)