Skip to content

Commit fda0221

Browse files
mszyprowdaeinki
authored andcommitted
drm/exynos: mixer: Fix enabling of the runtime power management
Runtime power management is essential for the Exynos Mixer driver operation. It should be enabled before adding its DRM component, because in some cases (when deferred probe takes place due to the IOMMU availability) the DRM driver might be initialized directly from the Mixer's component_add() call, what results in starting the driver operation without enabling the runtime power management. Signed-off-by: Marek Szyprowski <[email protected]> Signed-off-by: Inki Dae <[email protected]>
1 parent a046e7b commit fda0221

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/gpu/drm/exynos/exynos_mixer.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1244,9 +1244,11 @@ static int mixer_probe(struct platform_device *pdev)
12441244

12451245
platform_set_drvdata(pdev, ctx);
12461246

1247+
pm_runtime_enable(dev);
1248+
12471249
ret = component_add(&pdev->dev, &mixer_component_ops);
1248-
if (!ret)
1249-
pm_runtime_enable(dev);
1250+
if (ret)
1251+
pm_runtime_disable(dev);
12501252

12511253
return ret;
12521254
}

0 commit comments

Comments
 (0)