Skip to content

Commit fde9ec3

Browse files
committed
Merge tag 'reset-fixes-for-v5.16-2' of git://git.pengutronix.de/pza/linux into arm/fixes
Reset controller fixes for v5.16, part 2 Fix pm_runtime_resume_and_get() error handling in the reset-rzg2l-usbphy-ctrl driver. * tag 'reset-fixes-for-v5.16-2' of git://git.pengutronix.de/pza/linux: reset: renesas: Fix Runtime PM usage reset: tegra-bpmp: Revert Handle errors in BPMP response Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Olof Johansson <[email protected]>
2 parents 7ad8b2f + 92c959b commit fde9ec3

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

drivers/reset/reset-rzg2l-usbphy-ctrl.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,12 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
137137
dev_set_drvdata(dev, priv);
138138

139139
pm_runtime_enable(&pdev->dev);
140-
pm_runtime_resume_and_get(&pdev->dev);
140+
error = pm_runtime_resume_and_get(&pdev->dev);
141+
if (error < 0) {
142+
pm_runtime_disable(&pdev->dev);
143+
reset_control_assert(priv->rstc);
144+
return dev_err_probe(&pdev->dev, error, "pm_runtime_resume_and_get failed");
145+
}
141146

142147
/* put pll and phy into reset state */
143148
spin_lock_irqsave(&priv->lock, flags);

drivers/reset/tegra/reset-bpmp.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
2020
struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
2121
struct mrq_reset_request request;
2222
struct tegra_bpmp_message msg;
23-
int err;
2423

2524
memset(&request, 0, sizeof(request));
2625
request.cmd = command;
@@ -31,13 +30,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
3130
msg.tx.data = &request;
3231
msg.tx.size = sizeof(request);
3332

34-
err = tegra_bpmp_transfer(bpmp, &msg);
35-
if (err)
36-
return err;
37-
if (msg.rx.ret)
38-
return -EINVAL;
39-
40-
return 0;
33+
return tegra_bpmp_transfer(bpmp, &msg);
4134
}
4235

4336
static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,

0 commit comments

Comments
 (0)