objtool: Upgrade "Linked object detected" warning to error

jpoimboe · Peter Zijlstra · commit fdf5ff2934f4 · 2025-03-17T11:36:01.000+01:00
Force the user to fix their cmdline if they forget the '--link' option. Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Brendan Jackman <jackmanb@google.com> Link: https://lore.kernel.org/r/8380bbf3a0fa86e03fd63f60568ae06a48146bc1.1741975349.git.jpoimboe@kernel.org
diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
@@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv)
 		return 1;
 
 	if (!opts.link && has_multiple_files(file->elf)) {
-		ERROR("Linked object detected, forcing --link");
-		opts.link = true;
+		ERROR("Linked object requires --link");
+		goto err;
 	}
 
 	ret = check(file);

Original file line number	Diff line number	Diff line change
`@@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv)`
`198`	`198`	`return 1;`
`199`	`199`
`200`	`200`	`if (!opts.link && has_multiple_files(file->elf)) {`
`201`		`- ERROR("Linked object detected, forcing --link");`
`202`		`- opts.link = true;`
	`201`	`+ ERROR("Linked object requires --link");`
	`202`	`+ goto err;`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`ret = check(file);`