Skip to content

Commit fdffb7d

Browse files
vsyrjalatursulin
authored andcommitted
drm/i915/psr: Fix BDW PSR AUX CH data register offsets
The multiplication got replaced by an addition in some cleanup. This means we never write the correct data to some of the BDW PSR data registers and thus we fail to actually wake up the panel from PSR. Fixes: 4ab4fa1 ("drm/i915/psr: Make PSR registers relative to transcoders") Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jouni Högander <[email protected]> (cherry picked from commit 460dc4b) Signed-off-by: Tvrtko Ursulin <[email protected]>
1 parent 5b78263 commit fdffb7d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/display/intel_psr_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181

8282
#define _SRD_AUX_DATA_A 0x60814
8383
#define _SRD_AUX_DATA_EDP 0x6f814
84-
#define EDP_PSR_AUX_DATA(tran, i) _MMIO_TRANS2(tran, _SRD_AUX_DATA_A + (i) + 4) /* 5 registers */
84+
#define EDP_PSR_AUX_DATA(tran, i) _MMIO_TRANS2(tran, _SRD_AUX_DATA_A + (i) * 4) /* 5 registers */
8585

8686
#define _SRD_STATUS_A 0x60840
8787
#define _SRD_STATUS_EDP 0x6f840

0 commit comments

Comments
 (0)