Skip to content

Commit fe55ba1

Browse files
James-A-Clarkacmel
authored andcommitted
perf cs-etm: Remove unused stub methods
These aren't used outside of cs-etm so don't need stubs. Leave cs_etm__process_auxtrace_info() which is used externally, and add an error message so that it's obvious to users why it causes errors. Signed-off-by: James Clark <[email protected]> Cc: Al Grant <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: John Garry <[email protected]> Cc: Leo Yan <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Mathieu Poirier <[email protected]> Cc: Mike Leach <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Suzuki Poulouse <[email protected]> Cc: Will Deacon <[email protected]> Cc: [email protected] Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent ab6bd55 commit fe55ba1

File tree

1 file changed

+2
-32
lines changed

1 file changed

+2
-32
lines changed

tools/perf/util/cs-etm.h

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#ifndef INCLUDE__UTIL_PERF_CS_ETM_H__
88
#define INCLUDE__UTIL_PERF_CS_ETM_H__
99

10+
#include "debug.h"
1011
#include "util/event.h"
1112
#include <linux/bits.h>
1213

@@ -218,40 +219,9 @@ static inline int
218219
cs_etm__process_auxtrace_info(union perf_event *event __maybe_unused,
219220
struct perf_session *session __maybe_unused)
220221
{
222+
pr_err("\nCS ETM Trace: OpenCSD is not linked in, please recompile with CORESIGHT=1\n");
221223
return -1;
222224
}
223-
224-
static inline int cs_etm__get_cpu(u8 trace_chan_id __maybe_unused,
225-
int *cpu __maybe_unused)
226-
{
227-
return -1;
228-
}
229-
230-
static inline int cs_etm__etmq_set_tid(
231-
struct cs_etm_queue *etmq __maybe_unused,
232-
pid_t tid __maybe_unused,
233-
u8 trace_chan_id __maybe_unused)
234-
{
235-
return -1;
236-
}
237-
238-
static inline bool cs_etm__etmq_is_timeless(
239-
struct cs_etm_queue *etmq __maybe_unused)
240-
{
241-
/* What else to return? */
242-
return true;
243-
}
244-
245-
static inline void cs_etm__etmq_set_traceid_queue_timestamp(
246-
struct cs_etm_queue *etmq __maybe_unused,
247-
u8 trace_chan_id __maybe_unused) {}
248-
249-
static inline struct cs_etm_packet_queue *cs_etm__etmq_get_packet_queue(
250-
struct cs_etm_queue *etmq __maybe_unused,
251-
u8 trace_chan_id __maybe_unused)
252-
{
253-
return NULL;
254-
}
255225
#endif
256226

257227
#endif

0 commit comments

Comments
 (0)