Skip to content

Commit fea1120

Browse files
committed
mm/debug_vm_pgtable: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2] this[3] macro[4], just initialize this variable to NULL. [1] https://lore.kernel.org/lkml/[email protected]/ [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ Fixes: 399145f ("mm/debug: add tests validating architecture page table helpers") Reviewed-by: Nick Desaulniers <[email protected]> Signed-off-by: Kees Cook <[email protected]>
1 parent 4df7a75 commit fea1120

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/debug_vm_pgtable.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ static int __init debug_vm_pgtable(void)
307307
phys_addr_t paddr;
308308
unsigned long vaddr, pte_aligned, pmd_aligned;
309309
unsigned long pud_aligned, p4d_aligned, pgd_aligned;
310-
spinlock_t *uninitialized_var(ptl);
310+
spinlock_t *ptl = NULL;
311311

312312
pr_info("Validating architecture page table helpers\n");
313313
prot = vm_get_page_prot(VMFLAGS);

0 commit comments

Comments
 (0)