Skip to content

Commit feafeb5

Browse files
ahalaneyShawn Guo
authored andcommitted
arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
The deprecated property is named snps,reset-gpio, but this devicetree used snps,reset-gpios instead which results in the reset not being used and the following make dtbs_check error: ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml Use the preferred method of defining the reset gpio in the phy node itself. Note that this drops the 10 us pre-delay, but prior this wasn't used at all and a pre-delay doesn't make much sense in this context so it should be fine. Fixes: 8dd495d ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 916508c commit feafeb5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

arch/arm64/boot/dts/freescale/imx8dxl-evk.dts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@
121121
phy-handle = <&ethphy0>;
122122
nvmem-cells = <&fec_mac1>;
123123
nvmem-cell-names = "mac-address";
124-
snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
125-
snps,reset-delays-us = <10 20 200000>;
126124
status = "okay";
127125

128126
mdio {
@@ -136,6 +134,9 @@
136134
eee-broken-1000t;
137135
qca,disable-smarteee;
138136
qca,disable-hibernation-mode;
137+
reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
138+
reset-assert-us = <20>;
139+
reset-deassert-us = <200000>;
139140
vddio-supply = <&vddio0>;
140141

141142
vddio0: vddio-regulator {

0 commit comments

Comments
 (0)