Skip to content

Commit fed8d87

Browse files
Eric DeVolderbp3tk0v
authored andcommitted
x86/acpi/boot: Correct acpi_is_processor_usable() check
The logic in acpi_is_processor_usable() requires the online capable bit be set for hotpluggable CPUs. The online capable bit has been introduced in ACPI 6.3. However, for ACPI revisions < 6.3 which do not support that bit, CPUs should be reported as usable, not the other way around. Reverse the check. [ bp: Rewrite commit message. ] Fixes: e2869bd ("x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC") Suggested-by: Miguel Luis <[email protected]> Suggested-by: Boris Ostrovsky <[email protected]> Signed-off-by: Eric DeVolder <[email protected]> Signed-off-by: Borislav Petkov (AMD) <[email protected]> Tested-by: David R <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent a74fabf commit fed8d87

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/x86/kernel/acpi/boot.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,8 @@ static bool __init acpi_is_processor_usable(u32 lapic_flags)
197197
if (lapic_flags & ACPI_MADT_ENABLED)
198198
return true;
199199

200-
if (acpi_support_online_capable && (lapic_flags & ACPI_MADT_ONLINE_CAPABLE))
200+
if (!acpi_support_online_capable ||
201+
(lapic_flags & ACPI_MADT_ONLINE_CAPABLE))
201202
return true;
202203

203204
return false;

0 commit comments

Comments
 (0)