Skip to content

Commit ff30e45

Browse files
Bob Pearsonjgunthorpe
authored andcommitted
RDMA/rxe: Remove redundant scheduling of rxe_completer
In rxe_post_send_kernel() if the qp is in the error state after posting the work requests the rxe_completer() task is scheduled. But, the only way to move the qp into the error state is to call rxe_qp_error() which also schedules the rxe_completer() task to drain the queues. Calling it a second time has no effect. This commit removes the redundant call. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bob Pearson <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent b703374 commit ff30e45

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/infiniband/sw/rxe/rxe_verbs.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -907,11 +907,6 @@ static int rxe_post_send_kernel(struct rxe_qp *qp,
907907
if (good)
908908
rxe_sched_task(&qp->req.task);
909909

910-
spin_lock_irqsave(&qp->state_lock, flags);
911-
if (qp_state(qp) == IB_QPS_ERR)
912-
rxe_sched_task(&qp->comp.task);
913-
spin_unlock_irqrestore(&qp->state_lock, flags);
914-
915910
return err;
916911
}
917912

0 commit comments

Comments
 (0)