bcachefs: reduce stack usage in alloc_sectors_start()

Kent Overstreet · Kent Overstreet · commit ff6369da9ac3 · 2025-05-30T01:21:13.000-04:00
with typical config options, variables in different inline functions
aren't sharing stack space - and these are slowpaths.

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
@@ -1104,7 +1104,7 @@ static inline bool too_many_writepoints(struct bch_fs *c, unsigned factor)
 	return stranded * factor > free;
 }
 
-static bool try_increase_writepoints(struct bch_fs *c)
+static noinline bool try_increase_writepoints(struct bch_fs *c)
 {
 	struct write_point *wp;
 
@@ -1117,7 +1117,7 @@ static bool try_increase_writepoints(struct bch_fs *c)
 	return true;
 }
 
-static bool try_decrease_writepoints(struct btree_trans *trans, unsigned old_nr)
+static noinline bool try_decrease_writepoints(struct btree_trans *trans, unsigned old_nr)
 {
 	struct bch_fs *c = trans->c;
 	struct write_point *wp;

Original file line number	Diff line number	Diff line change
`@@ -1104,7 +1104,7 @@ static inline bool too_many_writepoints(struct bch_fs *c, unsigned factor)`
`1104`	`1104`	`return stranded * factor > free;`
`1105`	`1105`	`}`
`1106`	`1106`
`1107`		`-static bool try_increase_writepoints(struct bch_fs *c)`
	`1107`	`+static noinline bool try_increase_writepoints(struct bch_fs *c)`
`1108`	`1108`	`{`
`1109`	`1109`	`struct write_point *wp;`
`1110`	`1110`
`@@ -1117,7 +1117,7 @@ static bool try_increase_writepoints(struct bch_fs *c)`
`1117`	`1117`	`return true;`
`1118`	`1118`	`}`
`1119`	`1119`
`1120`		`-static bool try_decrease_writepoints(struct btree_trans *trans, unsigned old_nr)`
	`1120`	`+static noinline bool try_decrease_writepoints(struct btree_trans *trans, unsigned old_nr)`
`1121`	`1121`	`{`
`1122`	`1122`	`struct bch_fs *c = trans->c;`
`1123`	`1123`	`struct write_point *wp;`