Skip to content

Commit ff7a654

Browse files
alejandro-colomarkees
authored andcommitted
elf, uapi: Remove struct tag 'dynamic'
Such a generic struct tag shouldn't have been exposed in a public header. Since it's undocumented, we can assume it's a historical accident. And since no software (at least on Debian) relies on this tag, we can safely remove it. Here are the results of a Debian Code Search[1]: $ # packages that contain 'include [<"]linux/elf\.h[">]' $ curl -s https://codesearch.debian.net/results/e5e7c74dfcdae609/packages.txt > include $ # packages that contain '\bstruct dynamic\b' $ curl -s https://codesearch.debian.net/results/b23577e099048c6a/packages.txt > struct $ cat struct include | sort | uniq -d chromium hurd linux qemu qt6-webengine qtwebengine-opensource-src $ # chromium: Seems to hold a copy of the UAPI header. No uses of the tag. $ # hurd: Same thing as chromium. $ # linux: :) $ # qemu: Same thing as chromium. $ # qt6-webengine: Same thing as all. $ # qtwebengine-opensource-src: Yet another copy. Link: https://codesearch.debian.net/ [1] Link: https://lore.kernel.org/linux-mm/[email protected]/T/ Cc: "Eric W. Biederman" <[email protected]> Cc: Matthew Wilcox <[email protected]> Cc: David Howells <[email protected]> Cc: Rolf Eike Beer <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: "Paul E. McKenney" <[email protected]> Cc: Dave Jones <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]> Signed-off-by: Kees Cook <[email protected]>
1 parent ce9ecca commit ff7a654

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/uapi/linux/elf.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ typedef __s64 Elf64_Sxword;
140140
#define ELF64_ST_BIND(x) ELF_ST_BIND(x)
141141
#define ELF64_ST_TYPE(x) ELF_ST_TYPE(x)
142142

143-
typedef struct dynamic {
143+
typedef struct {
144144
Elf32_Sword d_tag;
145145
union {
146146
Elf32_Sword d_val;

0 commit comments

Comments
 (0)