Skip to content

Commit ff9166c

Browse files
dstarke-siemensgregkh
authored andcommitted
tty: n_gsm: fix incorrect UA handling
n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010. See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516 The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to the newer 27.010 here. Chapter 5.4.4.2 states that any received unnumbered acknowledgment (UA) with its poll/final (PF) bit set to 0 shall be discarded. Currently, all UA frame are handled in the same way regardless of the PF bit. This does not comply with the standard. Remove the UA case in gsm_queue() to process only UA frames with PF bit set to 1 to abide the standard. Fixes: e1eaea4 ("tty: n_gsm line discipline") Cc: [email protected] Signed-off-by: Daniel Starke <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 73029a4 commit ff9166c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/tty/n_gsm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1865,7 +1865,6 @@ static void gsm_queue(struct gsm_mux *gsm)
18651865
}
18661866
}
18671867
break;
1868-
case UA:
18691868
case UA|PF:
18701869
if (cr == 0 || dlci == NULL)
18711870
break;

0 commit comments

Comments
 (0)