Skip to content

Commit 2fd8418

Browse files
committed
Contributing: move Clippy up and to the bottom
Clippy is closer to building, and building the patches is the bare minimum, thus it makes sense to be higher than `rustfmt`. `checkpatch.pl` is important, but fairly well-known, so move it down so that other points are more prominent, especially the `CLIPPY=1` one now becomes the first one. Signed-off-by: Miguel Ojeda <[email protected]>
1 parent f2c8757 commit 2fd8418

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Contributing.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,10 @@ For new abstractions and modules, and especially for those that require new kern
100100

101101
The following items apply to every patch in a series. That is, in general, each commit should be clean, not just the end state.
102102

103-
- Please run your patch through the `scripts/checkpatch.pl` script. In particular, the `--codespell` option is useful to check patches for typos.
103+
- Please keep the code Clippy-clean by compiling with `CLIPPY=1`.
104104

105105
- Please format the code by running the `rustfmt` target. Please see the [style guidelines](https://docs.kernel.org/rust/coding-guidelines.html#style-formatting) as well.
106106

107-
- Please keep the code Clippy-clean by compiling with `CLIPPY=1`.
108-
109107
- When submitting changes to Rust code documentation, please render them using the `rustdoc` target and ensure the result looks as expected. The Rust code documentation gets rendered at <https://rust.docs.kernel.org>.
110108

111109
- When submitting changes to tests, including `#[test]`s, Kselftests and examples inside Rust code documentation (i.e. "doctests", which are transformed into KUnit tests), please [test them](https://docs.kernel.org/rust/testing.html).
@@ -114,6 +112,8 @@ The following items apply to every patch in a series. That is, in general, each
114112

115113
- Ideally, please check your changes with both the latest stable Rust compiler as well as the minimum supported version (`scripts/min-tool-version.sh rustc`), including Clippy.
116114

115+
- Please run your patch through the `scripts/checkpatch.pl` script. In particular, the `--codespell` option is useful to check patches for typos.
116+
117117
### Key cycle dates
118118

119119
- Patches can be sent anytime.

0 commit comments

Comments
 (0)