Bump crypto-bigint to v0.7.0-pre.5 (#533)

This notably adds `BoxedUint::from_be_slice_vartime` which has been
used where appropriate, namely for parsing signatures

Author: tarcieri

Cargo.lock

@@ -22,7 +22,7 @@ pkcs8 = { version = "0.11.0-rc.4", default-features = false, features = ["alloc"
 signature = { version = "3.0.0-rc.1", default-features = false, features = ["alloc", "digest", "rand_core"] }
 spki = { version = "0.8.0-rc.2", default-features = false, features = ["alloc"] }
 zeroize = { version = "1.5", features = ["alloc"] }
-crypto-bigint = { version = "0.7.0-pre.4", default-features = false, features = ["zeroize", "alloc"] }
+crypto-bigint = { version = "0.7.0-pre.5", default-features = false, features = ["zeroize", "alloc"] }
 crypto-primes = { version = "0.7.0-pre.1", default-features = false }
 
 # optional dependencies

Cargo.toml

@@ -118,7 +118,7 @@ impl SignatureScheme for Pkcs1v15Sign {
             pub_key,
             self.prefix.as_ref(),
             hashed,
-            &BoxedUint::from_be_slice(sig, sig.len() as u32 * 8)?,
+            &BoxedUint::from_be_slice_vartime(sig),
         )
     }
 }

src/pkcs1v15.rs

@@ -1,9 +1,9 @@
 //! `RSASSA-PKCS1-v1_5` signatures.
 
-use ::signature::SignatureEncoding;
 use alloc::boxed::Box;
 use core::fmt::{Debug, Display, Formatter, LowerHex, UpperHex};
 use crypto_bigint::BoxedUint;
+use signature::SignatureEncoding;
 
 #[cfg(feature = "serde")]
 use serdect::serde::{de, Deserialize, Serialize};
@@ -34,14 +34,8 @@ impl TryFrom<&[u8]> for Signature {
     type Error = signature::Error;
 
     fn try_from(bytes: &[u8]) -> signature::Result<Self> {
-        let len = bytes.len();
-        let inner = BoxedUint::from_be_slice(bytes, len as u32 * 8);
-        #[cfg(feature = "std")]
-        let inner = inner
-            .map_err(|e| Box::new(e) as Box<dyn core::error::Error + Send + Sync + 'static>)?;
-        #[cfg(not(feature = "std"))]
-        let inner = inner.map_err(|_| signature::Error::new())?;
-
+        // TODO(tarcieri): max length restriction? (#350)
+        let inner = BoxedUint::from_be_slice_vartime(bytes);
         Ok(Self { inner })
     }
 }

src/pkcs1v15/signature.rs

@@ -106,7 +106,7 @@ impl SignatureScheme for Pss {
         verify(
             pub_key,
             hashed,
-            &BoxedUint::from_be_slice(sig, sig.len() as u32 * 8)?,
+            &BoxedUint::from_be_slice_vartime(sig),
             sig.len(),
             &mut *self.digest,
             self.salt_len,

src/pss.rs

@@ -1,9 +1,9 @@
 //! `RSASSA-PSS` signatures.
 
-use ::signature::SignatureEncoding;
 use alloc::boxed::Box;
 use core::fmt::{Debug, Display, Formatter, LowerHex, UpperHex};
 use crypto_bigint::BoxedUint;
+use signature::SignatureEncoding;
 
 #[cfg(feature = "serde")]
 use serdect::serde::{de, Deserialize, Serialize};
@@ -34,15 +34,8 @@ impl TryFrom<&[u8]> for Signature {
     type Error = signature::Error;
 
     fn try_from(bytes: &[u8]) -> signature::Result<Self> {
-        let len = bytes.len();
-        let inner = BoxedUint::from_be_slice(bytes, len as u32 * 8);
-
-        #[cfg(feature = "std")]
-        let inner = inner
-            .map_err(|e| Box::new(e) as Box<dyn core::error::Error + Send + Sync + 'static>)?;
-        #[cfg(not(feature = "std"))]
-        let inner = inner.map_err(|_| signature::Error::new())?;
-
+        // TODO(tarcieri): max length restriction? (#350)
+        let inner = BoxedUint::from_be_slice_vartime(bytes);
         Ok(Self { inner })
     }
 }