Skip to content

[Invalid] rem function doesn't compute remainder #198

@kayabaNerve

Description

@kayabaNerve

I updated https://github.com/serai-dex/serai/blob/develop/crypto/dalek-ff-group/src/field.rs to v0.5, replacing the two .reduce calls with rem calls. I now have a test failure where 1 * 1, which should equal 1, is actually 26. It seems to me 0.5's rem is critically broken.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions