Skip to content

Commit 262f51c

Browse files
committed
ed448-goldilocks: reject identity points in Group::try_from_rng()
1 parent 9e8656b commit 262f51c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

ed448-goldilocks/src/decaf/points.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,10 @@ impl Group for DecafPoint {
178178

179179
loop {
180180
rng.try_fill_bytes(bytes.as_mut())?;
181-
if let Some(point) = Self::from_bytes(&bytes).into() {
181+
if let Some(point) = Self::from_bytes(&bytes)
182+
.into_option()
183+
.filter(|point| point != &Self::IDENTITY)
184+
{
182185
return Ok(point);
183186
}
184187
}

ed448-goldilocks/src/edwards/extended.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,10 @@ impl Group for EdwardsPoint {
345345

346346
loop {
347347
rng.try_fill_bytes(bytes.as_mut())?;
348-
if let Some(point) = Self::from_bytes(&bytes).into() {
348+
if let Some(point) = Self::from_bytes(&bytes)
349+
.into_option()
350+
.filter(|point| point != &Self::IDENTITY)
351+
{
349352
return Ok(point);
350353
}
351354
}

0 commit comments

Comments
 (0)