p256: use ecdsa::bench_ecdsa! macro (#1591)

Uses the macro introduced in RustCrypto/signtaures#1142 to write a basic
ECDSA benchmark that tests both signing and verification

Author: tarcieri

Cargo.lock

@@ -13,6 +13,6 @@ const FE_B: FieldElement = FieldElement::from_hex_vartime(
     "547ef835c3dac4fd97f8461a14611dc9c27745132ded8e545c1d54c72f046997",
 );
 
-primefield::bench_field!(bench_field_element, "FieldElement", FE_A, FE_B);
-criterion_group!(benches, bench_field_element);
+primefield::bench_field!(bench_ecdsa, "FieldElement", FE_A, FE_B);
+criterion_group!(benches, bench_ecdsa);
 criterion_main!(benches);

bp256/benches/field.rs

@@ -62,6 +62,11 @@ test-vectors = ["dep:hex-literal"]
 [package.metadata.docs.rs]
 all-features = true
 
+[[bench]]
+name = "ecdsa"
+harness = false
+required-features = ["ecdsa"]
+
 [[bench]]
 name = "field"
 harness = false

p256/Cargo.toml

@@ -0,0 +1,21 @@
+//! p256 ECDSA benchmarks
+
+use criterion::{criterion_group, criterion_main};
+use hex_literal::hex;
+use p256::ecdsa::{Signature, SigningKey};
+
+const SIGNING_KEY_BYTES: [u8; 32] =
+    hex!("1cf6bc6c7f642a84994119e206c9f0753ff100709f4fd12f2338c1be60bf4175");
+
+fn signing_key() -> SigningKey {
+    SigningKey::from_bytes(&SIGNING_KEY_BYTES.into()).unwrap()
+}
+
+ecdsa_core::bench_ecdsa!(
+    bench_ecdsa,
+    "ECDSA/P-256 (SHA-256)",
+    signing_key(),
+    Signature
+);
+criterion_group!(benches, bench_ecdsa);
+criterion_main!(benches);

p256/benches/ecdsa.rs

@@ -1,7 +1,7 @@
 /// Write a series of `criterion`-based benchmarks for a field implementation.
 #[macro_export]
 macro_rules! bench_field {
-    { $name:ident, $desc:expr, $fe_a:expr, $fe_b:expr } => {
+    ($name:ident, $desc:expr, $fe_a:expr, $fe_b:expr) => {
         fn bench_add<M: ::criterion::measurement::Measurement>(
             group: &mut ::criterion::BenchmarkGroup<'_, M>,
         ) {