clippy: fixup rust 1.83 warnings (#1640)

* pkcs12: clippy fixups

* crmf: clippy fixups

* cms: clippy fixups

* sec1: clippy fixups

* pkcs1: clippy fixups

* pkcs8: clippy fixups

* x509-cert: clippy fixups

* gss-api: clippy fixups

* spki: clippy fixups

* base64ct: clippy fixups

* der: clippy fixups

* pem-rfc7468: clippy fixups

* const-oid: clippy fixups

* serdect: clippy fixups

* tls-codec: clippy fixups

* const-oid: clippy fixup

Author: baloo

base64ct/src/decoder.rs

@@ -253,7 +253,7 @@ impl<'i, E: Encoding> Decoder<'i, E> {
 }
 
 #[cfg(feature = "std")]
-impl<'i, E: Encoding> io::Read for Decoder<'i, E> {
+impl<E: Encoding> io::Read for Decoder<'_, E> {
     fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
         if self.is_finished() {
             return Ok(0);
@@ -344,7 +344,7 @@ pub struct Line<'i> {
     remaining: &'i [u8],
 }
 
-impl<'i> Default for Line<'i> {
+impl Default for Line<'_> {
     fn default() -> Self {
         Self::new(&[])
     }

base64ct/src/encoder.rs

@@ -166,7 +166,7 @@ impl<'o, E: Encoding> Encoder<'o, E> {
 }
 
 #[cfg(feature = "std")]
-impl<'o, E: Encoding> io::Write for Encoder<'o, E> {
+impl<E: Encoding> io::Write for Encoder<'_, E> {
     fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
         self.encode(buf)?;
         Ok(buf.len())

cms/src/builder.rs

@@ -179,7 +179,7 @@ impl<'s> SignerInfoBuilder<'s> {
     }
 }
 
-impl<'s> Builder for SignerInfoBuilder<'s> {
+impl Builder for SignerInfoBuilder<'_> {
     type Output = SignerInfo;
 
     /// Calculate the data to be signed

const-oid/src/arcs.rs

@@ -111,7 +111,7 @@ impl<'a> Arcs<'a> {
     }
 }
 
-impl<'a> Iterator for Arcs<'a> {
+impl Iterator for Arcs<'_> {
     type Item = Arc;
 
     fn next(&mut self) -> Option<Arc> {

const-oid/src/encoder.rs

@@ -132,7 +132,7 @@ const fn base128_byte(arc: Arc, pos: usize, total: usize) -> Result<u8> {
     debug_assert!(pos < total);
     let last_byte = checked_add!(pos, 1) == total;
     let mask = if last_byte { 0 } else { 0b10000000 };
-    let shift = checked_sub!(checked_sub!(total, pos), 1) * 7;
+    let shift = checked_mul!(checked_sub!(checked_sub!(total, pos), 1), 7);
     Ok(((arc >> shift) & 0b1111111) as u8 | mask)
 }
 

crmf/src/pop.rs

@@ -248,7 +248,7 @@ impl<'a> ::der::Decode<'a> for EncKeyWithIdChoice<'a> {
         }
     }
 }
-impl<'a> ::der::EncodeValue for EncKeyWithIdChoice<'a> {
+impl ::der::EncodeValue for EncKeyWithIdChoice<'_> {
     fn encode_value(&self, encoder: &mut impl ::der::Writer) -> ::der::Result<()> {
         match self {
             Self::String(variant) => variant.encode_value(encoder),

der/src/arrayvec.rs

@@ -125,7 +125,7 @@ impl<'a, T> Iterator for Iter<'a, T> {
     }
 }
 
-impl<'a, T> ExactSizeIterator for Iter<'a, T> {}
+impl<T> ExactSizeIterator for Iter<'_, T> {}
 
 #[cfg(test)]
 #[allow(clippy::unwrap_used)]

der/src/asn1/bit_string.rs

@@ -190,7 +190,7 @@ impl<'a> TryFrom<BitStringRef<'a>> for &'a [u8] {
     }
 }
 
-impl<'a> FixedTag for BitStringRef<'a> {
+impl FixedTag for BitStringRef<'_> {
     const TAG: Tag = Tag::BitString;
 }
 
@@ -401,7 +401,7 @@ pub struct BitStringIter<'a> {
     position: usize,
 }
 
-impl<'a> Iterator for BitStringIter<'a> {
+impl Iterator for BitStringIter<'_> {
     type Item = bool;
 
     #[allow(clippy::arithmetic_side_effects)]
@@ -417,13 +417,13 @@ impl<'a> Iterator for BitStringIter<'a> {
     }
 }
 
-impl<'a> ExactSizeIterator for BitStringIter<'a> {
+impl ExactSizeIterator for BitStringIter<'_> {
     fn len(&self) -> usize {
         self.bit_string.bit_len()
     }
 }
 
-impl<'a> FusedIterator for BitStringIter<'a> {}
+impl FusedIterator for BitStringIter<'_> {}
 
 #[cfg(feature = "flagset")]
 impl<T: flagset::Flags> FixedTag for flagset::FlagSet<T> {

der/src/asn1/context_specific.rs

@@ -234,7 +234,7 @@ impl<'a, T> ContextSpecificRef<'a, T> {
     }
 }
 
-impl<'a, T> EncodeValue for ContextSpecificRef<'a, T>
+impl<T> EncodeValue for ContextSpecificRef<'_, T>
 where
     T: EncodeValue + Tagged,
 {
@@ -247,7 +247,7 @@ where
     }
 }
 
-impl<'a, T> Tagged for ContextSpecificRef<'a, T>
+impl<T> Tagged for ContextSpecificRef<'_, T>
 where
     T: Tagged,
 {

der/src/asn1/integer/int.rs

@@ -151,7 +151,7 @@ impl<'a> DecodeValue<'a> for IntRef<'a> {
     }
 }
 
-impl<'a> EncodeValue for IntRef<'a> {
+impl EncodeValue for IntRef<'_> {
     fn value_len(&self) -> Result<Length> {
         // Signed integers always hold their full encoded form.
         Ok(self.inner.len())
@@ -168,11 +168,11 @@ impl<'a> From<&IntRef<'a>> for IntRef<'a> {
     }
 }
 
-impl<'a> FixedTag for IntRef<'a> {
+impl FixedTag for IntRef<'_> {
     const TAG: Tag = Tag::Integer;
 }
 
-impl<'a> OrdIsValueOrd for IntRef<'a> {}
+impl OrdIsValueOrd for IntRef<'_> {}
 
 #[cfg(feature = "alloc")]
 mod allocating {