require pkcs8 for pkcs1 decode in rsa

stevefan1999-personal · stevefan1999-personal · commit bfa3dfb9c807 · 2024-12-07T15:16:58.000+08:00
diff --git a/src/sign/rsa.rs b/src/sign/rsa.rs
@@ -38,7 +38,7 @@ impl TryFrom<&PrivateKeyDer<'_>> for RsaSigningKey {
                 RsaPrivateKey::from_pkcs8_der(der.secret_pkcs8_der())
                     .map_err(|e| format!("failed to decrypt private key: {e}"))
             }
-            #[cfg(feature = "pkcs1")]
+            #[cfg(all(feature = "pkcs8", feature = "pkcs1"))]
             PrivateKeyDer::Pkcs1(der) => {
                 use pkcs1::DecodeRsaPrivateKey;
                 RsaPrivateKey::from_pkcs1_der(der.secret_pkcs1_der())

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ impl TryFrom<&PrivateKeyDer<'_>> for RsaSigningKey {`
`38`	`38`	`RsaPrivateKey::from_pkcs8_der(der.secret_pkcs8_der())`
`39`	`39`	`.map_err(\|e\| format!("failed to decrypt private key: {e}"))`
`40`	`40`	`}`
`41`		`- #[cfg(feature = "pkcs1")]`
	`41`	`+ #[cfg(all(feature = "pkcs8", feature = "pkcs1"))]`
`42`	`42`	`PrivateKeyDer::Pkcs1(der) => {`
`43`	`43`	`use pkcs1::DecodeRsaPrivateKey;`
`44`	`44`	`RsaPrivateKey::from_pkcs1_der(der.secret_pkcs1_der())`