signature: use &[&[u8]] for messages

Author: daxpedda

async-signature/tests/mock_impl.rs

@@ -11,7 +11,7 @@ struct Signature;
 struct MockSigner;
 
 impl AsyncSigner<Signature> for MockSigner {
-    async fn sign_async(&self, _msg: &[u8]) -> Result<Signature, Error> {
+    async fn sign_async(&self, _msg: &[&[u8]]) -> Result<Signature, Error> {
         unimplemented!("just meant to check compilation")
     }
 }
@@ -33,7 +33,7 @@ impl async_signature::AsyncRandomizedSigner<Signature> for MockSigner {
     >(
         &self,
         _rng: &mut R,
-        _msg: &[u8],
+        _msg: &[&[u8]],
     ) -> Result<Signature, Error> {
         unimplemented!("just meant to check compilation")
     }

signature/src/signer.rs

@@ -12,7 +12,7 @@ use crate::rand_core::{CryptoRng, TryCryptoRng};
 /// or connection to an HSM), returning a digital signature.
 pub trait Signer<S> {
     /// Sign the given message and return a digital signature
-    fn sign(&self, msg: &[u8]) -> S {
+    fn sign(&self, msg: &[&[u8]]) -> S {
         self.try_sign(msg).expect("signature operation failed")
     }
 
@@ -21,15 +21,15 @@ pub trait Signer<S> {
     ///
     /// The main intended use case for signing errors is when communicating
     /// with external signers, e.g. cloud KMS, HSMs, or other hardware tokens.
-    fn try_sign(&self, msg: &[u8]) -> Result<S, Error>;
+    fn try_sign(&self, msg: &[&[u8]]) -> Result<S, Error>;
 }
 
 /// Sign the provided message bytestring using `&mut Self` (e.g. an evolving
 /// cryptographic key such as a stateful hash-based signature), returning a
 /// digital signature.
 pub trait SignerMut<S> {
     /// Sign the given message, update the state, and return a digital signature.
-    fn sign(&mut self, msg: &[u8]) -> S {
+    fn sign(&mut self, msg: &[&[u8]]) -> S {
         self.try_sign(msg).expect("signature operation failed")
     }
 
@@ -38,12 +38,12 @@ pub trait SignerMut<S> {
     ///
     /// Signing can fail, e.g., if the number of time periods allowed by the
     /// current key is exceeded.
-    fn try_sign(&mut self, msg: &[u8]) -> Result<S, Error>;
+    fn try_sign(&mut self, msg: &[&[u8]]) -> Result<S, Error>;
 }
 
 /// Blanket impl of [`SignerMut`] for all [`Signer`] types.
 impl<S, T: Signer<S>> SignerMut<S> for T {
-    fn try_sign(&mut self, msg: &[u8]) -> Result<S, Error> {
+    fn try_sign(&mut self, msg: &[&[u8]]) -> Result<S, Error> {
         T::try_sign(self, msg)
     }
 }
@@ -86,7 +86,7 @@ pub trait DigestSigner<D: Digest, S> {
 #[cfg(feature = "rand_core")]
 pub trait RandomizedSigner<S> {
     /// Sign the given message and return a digital signature
-    fn sign_with_rng<R: CryptoRng + ?Sized>(&self, rng: &mut R, msg: &[u8]) -> S {
+    fn sign_with_rng<R: CryptoRng + ?Sized>(&self, rng: &mut R, msg: &[&[u8]]) -> S {
         self.try_sign_with_rng(rng, msg)
             .expect("signature operation failed")
     }
@@ -99,7 +99,7 @@ pub trait RandomizedSigner<S> {
     fn try_sign_with_rng<R: TryCryptoRng + ?Sized>(
         &self,
         rng: &mut R,
-        msg: &[u8],
+        msg: &[&[u8]],
     ) -> Result<S, Error>;
 }
 
@@ -130,7 +130,7 @@ pub trait RandomizedDigestSigner<D: Digest, S> {
 #[cfg(feature = "rand_core")]
 pub trait RandomizedSignerMut<S> {
     /// Sign the given message, update the state, and return a digital signature.
-    fn sign_with_rng<R: CryptoRng + ?Sized>(&mut self, rng: &mut R, msg: &[u8]) -> S {
+    fn sign_with_rng<R: CryptoRng + ?Sized>(&mut self, rng: &mut R, msg: &[&[u8]]) -> S {
         self.try_sign_with_rng(rng, msg)
             .expect("signature operation failed")
     }
@@ -143,7 +143,7 @@ pub trait RandomizedSignerMut<S> {
     fn try_sign_with_rng<R: TryCryptoRng + ?Sized>(
         &mut self,
         rng: &mut R,
-        msg: &[u8],
+        msg: &[&[u8]],
     ) -> Result<S, Error>;
 }
 
@@ -153,7 +153,7 @@ impl<S, T: RandomizedSigner<S>> RandomizedSignerMut<S> for T {
     fn try_sign_with_rng<R: TryCryptoRng + ?Sized>(
         &mut self,
         rng: &mut R,
-        msg: &[u8],
+        msg: &[&[u8]],
     ) -> Result<S, Error> {
         T::try_sign_with_rng(self, rng, msg)
     }
@@ -169,14 +169,14 @@ pub trait AsyncSigner<S> {
     ///
     /// The main intended use case for signing errors is when communicating
     /// with external signers, e.g. cloud KMS, HSMs, or other hardware tokens.
-    async fn sign_async(&self, msg: &[u8]) -> Result<S, Error>;
+    async fn sign_async(&self, msg: &[&[u8]]) -> Result<S, Error>;
 }
 
 impl<S, T> AsyncSigner<S> for T
 where
     T: Signer<S>,
 {
-    async fn sign_async(&self, msg: &[u8]) -> Result<S, Error> {
+    async fn sign_async(&self, msg: &[&[u8]]) -> Result<S, Error> {
         self.try_sign(msg)
     }
 }
@@ -198,7 +198,7 @@ where
 #[cfg(feature = "rand_core")]
 pub trait AsyncRandomizedSigner<S> {
     /// Sign the given message and return a digital signature
-    async fn sign_with_rng_async<R: CryptoRng + ?Sized>(&self, rng: &mut R, msg: &[u8]) -> S {
+    async fn sign_with_rng_async<R: CryptoRng + ?Sized>(&self, rng: &mut R, msg: &[&[u8]]) -> S {
         self.try_sign_with_rng_async(rng, msg)
             .await
             .expect("signature operation failed")
@@ -212,7 +212,7 @@ pub trait AsyncRandomizedSigner<S> {
     async fn try_sign_with_rng_async<R: TryCryptoRng + ?Sized>(
         &self,
         rng: &mut R,
-        msg: &[u8],
+        msg: &[&[u8]],
     ) -> Result<S, Error>;
 }
 
@@ -224,7 +224,7 @@ where
     async fn try_sign_with_rng_async<R: TryCryptoRng + ?Sized>(
         &self,
         rng: &mut R,
-        msg: &[u8],
+        msg: &[&[u8]],
     ) -> Result<S, Error> {
         self.try_sign_with_rng(rng, msg)
     }

signature/src/verifier.rs

@@ -11,7 +11,7 @@ pub trait Verifier<S> {
     /// bytestring is authentic.
     ///
     /// Returns `Error` if it is inauthentic, or otherwise returns `()`.
-    fn verify(&self, msg: &[u8], signature: &S) -> Result<(), Error>;
+    fn verify(&self, msg: &[&[u8]], signature: &S) -> Result<(), Error>;
 }
 
 /// Verify the provided signature for the given prehashed message [`Digest`]