Migrate to universal-hash 0.5

This commit just switches to the new traits, and pretends that the
ideal number of parallel blocks is 1 (i.e. no faster than before).

Author: str4d

Cargo.lock

@@ -5,3 +5,6 @@ members = [
     "polyval"
 ]
 resolver = "2"
+
+[patch.crates-io]
+universal-hash = { git = "https://github.com/RustCrypto/traits", rev = "74ce6e7a9ab1243f574b6c37e747a6e54c01f376" }

Cargo.toml

@@ -3,7 +3,7 @@
 extern crate test;
 
 use ghash::{
-    universal_hash::{NewUniversalHash, UniversalHash},
+    universal_hash::{KeyInit, UniversalHash},
     GHash,
 };
 use test::Bencher;

ghash/benches/ghash.rs

@@ -33,7 +33,11 @@
 pub use polyval::universal_hash;
 
 use polyval::Polyval;
-use universal_hash::{consts::U16, NewUniversalHash, UniversalHash};
+use universal_hash::{
+    consts::U16,
+    crypto_common::{BlockSizeUser, KeySizeUser, ParBlocksSizeUser},
+    KeyInit, UhfBackend, UniversalHash,
+};
 
 #[cfg(feature = "zeroize")]
 use zeroize::Zeroize;
@@ -45,7 +49,7 @@ pub type Key = universal_hash::Key<GHash>;
 pub type Block = universal_hash::Block<GHash>;
 
 /// GHASH tags (16-bytes)
-pub type Tag = universal_hash::Output<GHash>;
+pub type Tag = universal_hash::Block<GHash>;
 
 /// **GHASH**: universal hash over GF(2^128) used by AES-GCM.
 ///
@@ -54,9 +58,11 @@ pub type Tag = universal_hash::Output<GHash>;
 #[derive(Clone)]
 pub struct GHash(Polyval);
 
-impl NewUniversalHash for GHash {
+impl KeySizeUser for GHash {
     type KeySize = U16;
+}
 
+impl KeyInit for GHash {
     /// Initialize GHASH with the given `H` field element
     #[inline]
     fn new(h: &Key) -> Self {
@@ -79,29 +85,36 @@ impl NewUniversalHash for GHash {
     }
 }
 
-impl UniversalHash for GHash {
+impl BlockSizeUser for GHash {
     type BlockSize = U16;
+}
 
-    /// Input a field element `X` to be authenticated
-    #[inline]
-    fn update(&mut self, x: &Block) {
+impl ParBlocksSizeUser for GHash {
+    type ParBlocksSize = U16;
+}
+
+impl UhfBackend for GHash {
+    fn proc_block(&mut self, x: &Block) {
         let mut x = *x;
         x.reverse();
-        self.0.update(&x);
+        self.0.proc_block(&x);
     }
+}
 
-    /// Reset internal state
-    #[inline]
-    fn reset(&mut self) {
-        self.0.reset();
+impl UniversalHash for GHash {
+    fn update_with_backend(
+        &mut self,
+        f: impl universal_hash::UhfClosure<BlockSize = Self::BlockSize>,
+    ) {
+        f.call(self);
     }
 
     /// Get GHASH output
     #[inline]
     fn finalize(self) -> Tag {
-        let mut output = self.0.finalize().into_bytes();
+        let mut output = self.0.finalize();
         output.reverse();
-        Tag::new(output)
+        output.into()
     }
 }
 

ghash/src/lib.rs

@@ -1,5 +1,5 @@
 use ghash::{
-    universal_hash::{NewUniversalHash, UniversalHash},
+    universal_hash::{KeyInit, UniversalHash},
     GHash,
 };
 use hex_literal::hex;
@@ -19,9 +19,8 @@ const GHASH_RESULT: [u8; 16] = hex!("bd9b3997046731fb96251b91f9c99d7a");
 #[test]
 fn ghash_test_vector() {
     let mut ghash = GHash::new(&H.into());
-    ghash.update(&X_1.into());
-    ghash.update(&X_2.into());
+    ghash.update(&[X_1.into(), X_2.into()]);
 
     let result = ghash.finalize();
-    assert_eq!(&GHASH_RESULT[..], result.into_bytes().as_slice());
+    assert_eq!(&GHASH_RESULT[..], result.as_slice());
 }

ghash/tests/lib.rs

@@ -14,7 +14,7 @@ edition = "2021"
 
 [dependencies]
 opaque-debug = "0.3"
-universal-hash = { version = "0.4", default-features = false }
+universal-hash = { version = "0.5", default-features = false }
 zeroize = { version = "1", optional = true, default-features = false }
 
 [target.'cfg(any(target_arch = "x86_64", target_arch = "x86"))'.dependencies]

poly1305/Cargo.toml

@@ -3,7 +3,7 @@
 extern crate test;
 
 use poly1305::{
-    universal_hash::{NewUniversalHash, UniversalHash},
+    universal_hash::{KeyInit, UniversalHash},
     Poly1305,
 };
 use test::Bencher;

poly1305/benches/poly1305.rs

@@ -35,16 +35,6 @@ impl State {
         Self { inner, token }
     }
 
-    /// Reset internal state
-    #[inline]
-    pub(crate) fn reset(&mut self) {
-        if self.token.get() {
-            unsafe { (*self.inner.avx2).reset() }
-        } else {
-            unsafe { (*self.inner.soft).reset() }
-        }
-    }
-
     /// Compute a Poly1305 block
     #[inline]
     pub(crate) fn compute_block(&mut self, block: &Block, partial: bool) {

poly1305/src/backend/autodetect.rs

@@ -60,12 +60,6 @@ impl State {
         }
     }
 
-    /// Reset internal state
-    pub(crate) fn reset(&mut self) {
-        self.initialized = None;
-        self.num_cached_blocks = 0;
-    }
-
     /// Compute a Poly1305 block
     #[target_feature(enable = "avx2")]
     pub(crate) unsafe fn compute_block(&mut self, block: &Block, partial: bool) {
@@ -152,6 +146,6 @@ impl State {
         };
         tag_int.write(tag.as_mut_slice());
 
-        Tag::new(tag)
+        tag.into()
     }
 }

poly1305/src/backend/avx2.rs

@@ -41,11 +41,6 @@ impl State {
         poly
     }
 
-    /// Reset internal state
-    pub(crate) fn reset(&mut self) {
-        self.h = Default::default();
-    }
-
     /// Compute a Poly1305 block
     pub(crate) fn compute_block(&mut self, block: &Block, partial: bool) {
         let hibit = if partial { 0 } else { 1 << 24 };
@@ -227,7 +222,7 @@ impl State {
         tag[8..12].copy_from_slice(&h2.to_le_bytes());
         tag[12..16].copy_from_slice(&h3.to_le_bytes());
 
-        Tag::new(tag)
+        tag.into()
     }
 }