Cargo.toml: add workspace-level clippy config (#1411)

Adds a set of workspace-level lints including common ones we've used in
the past and others collected via running `clippy::pedantic` on several
of our crates and looking for interesting ones.

Workspace-level lints require explict opt-in from each crate's
Cargo.toml, so there's nothing forcing any crate to use them:

    [lints]
    workspace = true

That said, I have opted every crate in the workspace into these lints
and gotten them all to pass except for `wycheproof2blb` which is an
internal utility tool and I didn't feel like it was worth the hassle.

Even then, the lints are all set to `"warn"`, so they can be easily
overridden by `#[allow(...)]` attributes, including `#![allow(...)]` to
shut them off at the granularity of an entire crate.

I managed to fix most of the issues that `cargo clippy --fix` didn't fix
automatically including some missing documentation and documentation
formatting issues.

The main thing I didn't fix was adding missing `SAFETY` comments, which
is a problem with a few of the crates in this repo. I disabled a lint at
the crate level and added a TODO where we're missing them and it wasn't
easily corrected.

Author: tarcieri

.clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-consts = true
+allow-unwrap-in-tests = true

.github/workflows/blobby.yml

@@ -2,9 +2,9 @@ name: blobby
 
 on:
   pull_request:
-      paths:
-        - "blobby/**"
-        - "Cargo.*"
+    paths:
+      - "blobby/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -38,11 +38,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test
-
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}

.github/workflows/block-buffer.yml

@@ -2,9 +2,9 @@ name: block-buffer
 
 on:
   pull_request:
-      paths:
-        - "block-buffer/**"
-        - "Cargo.*"
+    paths:
+      - "block-buffer/**"
+      - "Cargo.*"
   push:
     branches: master
 

.github/workflows/block-padding.yml

@@ -2,9 +2,9 @@ name: block-padding
 
 on:
   pull_request:
-      paths:
-        - "block-padding/**"
-        - "Cargo.*"
+    paths:
+      - "block-padding/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -47,7 +47,7 @@ jobs:
   minimal-versions:
     uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
     with:
-        working-directory: ${{ github.workflow }}
+      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/cpufeatures.yml

@@ -28,7 +28,7 @@ jobs:
   minimal-versions:
     uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
     with:
-        working-directory: ${{ github.workflow }}
+      working-directory: ${{ github.workflow }}
 
   # Linux tests
   linux:
@@ -56,8 +56,6 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: ${{ matrix.deps }}
       - run: cargo test --target ${{ matrix.target }}
 
@@ -76,8 +74,6 @@ jobs:
         with:
           toolchain: ${{ matrix.toolchain }}
           targets: x86_64-apple-darwin
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test
 
   # Windows tests
@@ -98,8 +94,6 @@ jobs:
         with:
           toolchain: ${{ matrix.toolchain }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test --target ${{ matrix.target }}
 
   # Cross-compiled tests
@@ -121,8 +115,6 @@ jobs:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
       - uses: RustCrypto/actions/cross-install@master
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cross test --target ${{ matrix.target }}
 
   # Build-only tests

.github/workflows/hex-literal.yml

@@ -2,9 +2,9 @@ name: hex-literal
 
 on:
   pull_request:
-      paths:
-        - "hex-literal/**"
-        - "Cargo.*"
+    paths:
+      - "hex-literal/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -42,14 +42,12 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo build --target ${{ matrix.target }}
 
   minimal-versions:
     uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
     with:
-        working-directory: ${{ github.workflow }}
+      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest
@@ -64,6 +62,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test

.github/workflows/inout.yml

@@ -2,9 +2,9 @@ name: inout
 
 on:
   pull_request:
-      paths:
-        - "inout/**"
-        - "Cargo.*"
+    paths:
+      - "inout/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -48,7 +48,7 @@ jobs:
   minimal-versions:
     uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
     with:
-        working-directory: ${{ github.workflow }}
+      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/opaque-debug.yml

@@ -2,9 +2,9 @@ name: opaque-debug
 
 on:
   pull_request:
-      paths:
-        - "opaque-debug/**"
-        - "Cargo.*"
+    paths:
+      - "opaque-debug/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -42,15 +42,8 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
-
   test:
     runs-on: ubuntu-latest
     strategy:
@@ -64,6 +57,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test

Cargo.toml

@@ -29,3 +29,42 @@ opt-level = 2
 
 [patch.crates-io]
 cmov = { path = "cmov" }
+
+[workspace.lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+doc_markdown = "warn"
+from_iter_instead_of_collect = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+implicit_saturating_sub = "warn"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+[workspace.lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"

blobby/Cargo.toml

@@ -13,3 +13,6 @@ description = "Iterator over simple binary blob storage"
 
 [features]
 alloc = []
+
+[lints]
+workspace = true