block-padding: remove unsafe code

Author: newpavlov

Cargo.lock

@@ -13,4 +13,4 @@ categories = ["cryptography", "no-std"]
 readme = "README.md"
 
 [dependencies]
-hybrid-array = "0.4"
+hybrid-array = "0.4.2"

block-padding/Cargo.toml

@@ -8,6 +8,7 @@
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg"
 )]
+#![deny(unsafe_code)]
 #![warn(missing_docs)]
 
 pub use hybrid_array as array;
@@ -64,7 +65,7 @@ pub trait Padding {
     /// Unpad data in the `blocks`.
     ///
     /// Returns `Err(UnpadError)` if the block contains malformed padding.
-    fn unpad_blocks<BlockSize: ArraySize>(
+    fn unpad_blocks<const N: usize, BlockSize: ArraySize<ArrayType<u8> = [u8; N]>>(
         blocks: &[Array<u8, BlockSize>],
     ) -> Result<&[u8], UnpadError> {
         let bs = BlockSize::USIZE;
@@ -78,11 +79,8 @@ pub trait Padding {
             (None, PadType::Ambiguous) => 0,
             (None, PadType::Reversible) => return Err(UnpadError),
         };
-        // SAFETY: `res_len` is always smaller or equal to `bs * blocks.len()`
-        Ok(unsafe {
-            let p = blocks.as_ptr() as *const u8;
-            core::slice::from_raw_parts(p, res_len)
-        })
+        let data = Array::slice_as_flattened(blocks);
+        Ok(&data[..res_len])
     }
 }