Fixes

Author: tarcieri

blobby/src/decode.rs

@@ -136,7 +136,7 @@ pub const fn parse_into_array<const ITEMS_LEN: usize, const DEDUP_LEN: usize>(
 /// Parse blobby data into a vector of slices.
 ///
 /// # Errors
-/// - if data failed to parse successfully
+/// If data failed to parse successfully
 #[cfg(feature = "alloc")]
 #[allow(clippy::missing_panics_doc, clippy::panic_in_result_fn)]
 pub fn parse_into_vec(mut data: &[u8]) -> Result<alloc::vec::Vec<&[u8]>, Error> {

block-buffer/src/lib.rs

@@ -145,7 +145,7 @@ impl<BS: ArraySize, K: BufferKind> BlockBuffer<BS, K> {
     /// Create new buffer from slice.
     ///
     /// # Errors
-    /// - if slice length is not valid for used buffer kind.
+    /// If slice length is not valid for used buffer kind.
     #[inline(always)]
     pub fn try_new(buf: &[u8]) -> Result<Self, Error> {
         const {

block-padding/src/lib.rs

@@ -24,7 +24,7 @@ pub trait Padding: 'static {
     /// Unpad data in `block`.
     ///
     /// # Errors
-    /// - if the block contains malformed padding.
+    /// If the block contains malformed padding.
     fn raw_unpad(block: &[u8]) -> Result<&[u8], Error>;
 
     /// Pads `block` filled with data up to `pos` (i.e the message length
@@ -41,7 +41,7 @@ pub trait Padding: 'static {
     /// Unpad data in `block`.
     ///
     /// # Errors
-    /// - if the block contains malformed padding.
+    /// If the block contains malformed padding.
     #[inline]
     fn unpad<BlockSize: ArraySize>(block: &Array<u8, BlockSize>) -> Result<&[u8], Error> {
         Self::raw_unpad(block.as_slice())
@@ -67,7 +67,7 @@ pub trait Padding: 'static {
     /// Unpad data in `blocks` and return unpadded byte slice.
     ///
     /// # Errors
-    /// - if `blocks` contain malformed padding.
+    /// If `blocks` contain malformed padding.
     #[inline]
     #[allow(clippy::panic_in_result_fn)]
     fn unpad_blocks<BlockSize: ArraySize>(blocks: &[Array<u8, BlockSize>]) -> Result<&[u8], Error> {
@@ -184,11 +184,10 @@ impl Pkcs7 {
 
 impl Padding for Pkcs7 {
     #[inline]
-    #[allow(clippy::cast_possible_truncation)]
     fn raw_pad(block: &mut [u8], pos: usize) {
         assert!(block.len() <= 255, "block size is too big for PKCS#7");
         assert!(pos < block.len(), "`pos` is bigger or equal to block size");
-        let n = (block.len() - pos) as u8;
+        let n = u8::try_from(block.len() - pos).expect("overflow");
         block[pos..].fill(n);
     }
 

cmov/tests/core_impls.rs

@@ -1,6 +1,10 @@
 //! Tests for `Cmov`/`CmovEq` impls on `core` types.
 
-#![allow(trivial_numeric_casts)]
+#![allow(
+    trivial_numeric_casts,
+    clippy::cast_possible_truncation,
+    clippy::cast_sign_loss
+)]
 
 /// Write the tests for an integer type, given two unequal integers
 macro_rules! int_tests {

cpufeatures/src/aarch64.rs

@@ -135,7 +135,7 @@ macro_rules! check {
 /// <https://developer.apple.com/documentation/kernel/1387446-sysctlbyname>
 ///
 /// # Panics
-/// - if `name` is not NUL terminated
+/// If `name` is not NUL terminated
 #[cfg(target_vendor = "apple")]
 #[must_use]
 pub unsafe fn sysctlbyname(name: &[u8]) -> bool {

inout/src/inout_buf.rs

@@ -67,7 +67,7 @@ impl<'inp, 'out, T> InOutBuf<'inp, 'out, T> {
     /// Create `InOutBuf` from immutable and mutable slices.
     ///
     /// # Errors
-    /// - if length of slices is not equal to each other.
+    /// If length of slices is not equal to each other.
     #[inline(always)]
     pub fn new(in_buf: &'inp [T], out_buf: &'out mut [T]) -> Result<Self, NotEqualError> {
         if in_buf.len() != out_buf.len() {

inout/src/reserved.rs

@@ -24,7 +24,7 @@ impl<'a, T> InOutBufReserved<'a, 'a, T> {
     /// Crate [`InOutBufReserved`] from a single mutable slice.
     ///
     /// # Errors
-    /// - if `out` is too small.
+    /// If `out` is too small.
     pub fn from_mut_slice(buf: &'a mut [T], msg_len: usize) -> Result<Self, OutIsTooSmallError> {
         if msg_len > buf.len() {
             return Err(OutIsTooSmallError);
@@ -122,7 +122,7 @@ impl<'inp, 'out, T> InOutBufReserved<'inp, 'out, T> {
     /// Crate [`InOutBufReserved`] from two separate slices.
     ///
     /// # Errors
-    /// - if `out` is too small.
+    /// If `out` is too small.
     pub fn from_slices(
         in_buf: &'inp [T],
         out_buf: &'out mut [T],
@@ -165,7 +165,7 @@ impl<'inp, 'out> InOutBufReserved<'inp, 'out, u8> {
     /// Transform buffer into [`PaddedInOutBuf`] using padding algorithm `P`.
     ///
     /// # Errors
-    /// - if the padding is invalid
+    /// If the padding is invalid
     #[inline(always)]
     #[allow(clippy::missing_panics_doc, clippy::panic_in_result_fn)]
     pub fn into_padded_blocks<P, BS>(self) -> Result<PaddedInOutBuf<'inp, 'out, BS>, PadError>

wycheproof2blb/src/wycheproof.rs

@@ -1,5 +1,6 @@
 //! Helpers for retrieving Wycheproof test vectors.
 
+use core::fmt;
 use serde::Deserialize;
 
 /// `Suite` represents the common elements of the top level object in a Wycheproof json
@@ -36,8 +37,8 @@ pub enum CaseResult {
     Acceptable,
 }
 
-impl core::fmt::Display for CaseResult {
-    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+impl fmt::Display for CaseResult {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(
             f,
             "{}",

zeroize/tests/zeroize.rs

@@ -3,17 +3,15 @@
 #![allow(
     clippy::missing_safety_doc,
     clippy::std_instead_of_alloc,
-    clippy::std_instead_of_core,
-    clippy::undocumented_unsafe_blocks,
-    clippy::unwrap_used
+    clippy::undocumented_unsafe_blocks
 )]
 
-use std::{
+use core::{
     marker::{PhantomData, PhantomPinned},
     mem::{MaybeUninit, size_of},
     num::*,
-    sync::Arc,
 };
+use std::sync::Arc;
 use zeroize::*;
 
 #[cfg(feature = "std")]